-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pdfjs-dist to 4.2.67 or later #1093
Comments
Should be fixed via #1092 I suppose? |
Cve is resolved, but updating would give some other benefits anyway |
Yea, worth noting though that pdfjs 4.x has major breaking changes. When I looked at it, it seemed like it would require major rewrites to this package. Not that it's impossible, of course, but certainly not a quick thing. At the very least though this issue is probably a duplicate of #1078 |
Yeah, |
Yes, 2 -> 3 was a major version in terms of semver, but wasnt too bad. 3 --> 4 is much bigger, imho of course, see https://github.com/mozilla/pdf.js/releases/tag/v4.0.189 I havent looked at it again, again its of course not impossible but unfortunately I think significantly more |
I would also prefer to have it upgraded. Npm still mentioned in version But they mentioned an workaround to set the option |
In my understanding, it is done in this library to disable this option. This was patched here: #1092 The best and safest would be of course to upgrade the pdfjs-dist to the latest version, but I'm not sure if it's happening anytime soon. |
It was fixed in this for me, thanks alot! #1092 |
Updating to version 4 and above would fix this #624 and possibly also this #824 (Note that 824 is not complete, but a stale bot forced it to be completed anyway...)
These are possibly breaking changes according to release notes from https://github.com/mozilla/pdf.js/releases/tag/v4.0.189. I have highlighted (points 3 & 5) that may pose a challenge:
|
Bug Report or Feature Request (mark with an
x
)The text was updated successfully, but these errors were encountered: