You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Feature Request: I would like to have support github attestations during the announce phase with ability to filter on what the subjects should be. See example working workflow astral-sh/uv#11357
Problem: Even though there's support already for github attestations via github-attestations = true, it only works when build-local-artifacts is used, which is not the case in the above scenario/workflow. In addition it would be desirable to be able to configure what gets attested and becomes part of the subject versus what does not, as shown in the above workflow.
Proposal:
Support actions/attest-build-provenance@v2 on announce phase. This could be introduced by adding a github_attestations_phase configuration variable that takes either announce or build-local-artifacts, defaulting to build-local-artifacts for backwards compatibility and modifying publish_github.yml.j2 to support it.
Support filters for attestations in announce phase. This could also be done by adding a github_attestations_filters configuration variable that is an array of strings that will be passed down to subject-path in attest-build-provenance in the announce phase. This can default to None for backwards compatibility. For example, in case of build-local-artifacts it should result in the current target/distrib/*${{ join(matrix.targets, ', ') }}*", but when used with announce it will result in artifacts/* by default or when adding more filters ['*.json', '*.sh', '*.ps1', '*.zip', '*.tar.gz'] it would work for example as shown below.
Feature Request: I would like to have support github attestations during the
announce
phase with ability to filter on what the subjects should be. See example working workflow astral-sh/uv#11357Problem: Even though there's support already for github attestations via
github-attestations = true
, it only works whenbuild-local-artifacts
is used, which is not the case in the above scenario/workflow. In addition it would be desirable to be able to configure what gets attested and becomes part of the subject versus what does not, as shown in the above workflow.Proposal:
Support
actions/attest-build-provenance@v2
onannounce
phase. This could be introduced by adding agithub_attestations_phase
configuration variable that takes eitherannounce
orbuild-local-artifacts
, defaulting tobuild-local-artifacts
for backwards compatibility and modifyingpublish_github.yml.j2
to support it.Support filters for attestations in announce phase. This could also be done by adding a
github_attestations_filters
configuration variable that is an array of strings that will be passed down tosubject-path
inattest-build-provenance
in theannounce
phase. This can default toNone
for backwards compatibility. For example, in case ofbuild-local-artifacts
it should result in the currenttarget/distrib/*${{ join(matrix.targets, ', ') }}*"
, but when used withannounce
it will result inartifacts/*
by default or when adding more filters['*.json', '*.sh', '*.ps1', '*.zip', '*.tar.gz']
it would work for example as shown below.I'd appreciate any thoughts/guidance here if this is achievable or something you'd be happy to support from an external contribution 😄
The text was updated successfully, but these errors were encountered: