Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to compile v0.28.0 #1771

Open
Sky9x opened this issue Feb 23, 2025 · 9 comments
Open

Unable to compile v0.28.0 #1771

Sky9x opened this issue Feb 23, 2025 · 9 comments

Comments

@Sky9x
Copy link

Sky9x commented Feb 23, 2025 •
edited
Loading

cargo install cargo-dist@0.28.0:

error[E0599]: the method `as_dyn_error` exists for reference `&ParseError`, but its trait bounds were not satisfied
  --> /home/sky9/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/cargo-dist-0.28.0/src/errors.rs:74:13
   |
74 |     #[error(transparent)]
   |             ^^^^^^^^^^^ method cannot be called on `&ParseError` due to unsatisfied trait bounds
   |
  ::: /home/sky9/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/target-lexicon-0.12.16/src/parse_error.rs:8:1
   |
8  | pub enum ParseError {
   | ------------------- doesn't satisfy `_: AsDynError<'_>` or `_: Error`
   |
   = note: the following trait bounds were not satisfied:
           `cargo_dist_schema::target_lexicon::ParseError: StdError`
           which is required by `cargo_dist_schema::target_lexicon::ParseError: AsDynError<'_>`
           `&cargo_dist_schema::target_lexicon::ParseError: StdError`
           which is required by `&cargo_dist_schema::target_lexicon::ParseError: AsDynError<'_>`

For more information about this error, try `rustc --explain E0599`.
error: could not compile `cargo-dist` (lib) due to 1 previous error
error: failed to compile `cargo-dist v0.28.0`, intermediate artifacts can be found at `/tmp/cargo-installB7Xz8H`.
To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.

The issue seems to be related to the target-lexicon crate.
The unlocked build compiles both target-lexicon versions 0.12.16 AND 0.13.2, but the --locked install (which works) only builds v0.12.16.

Cloning the current repo, running cargo update and then cargo build fails with the same error.

Before:

$ cargo tree --invert --package target-lexicon
target-lexicon v0.12.16
├── cfg-expr v0.15.8
│   └── target-spec v3.1.0
│       └── guppy v0.17.5
│           └── axoproject v1.0.0-rc.1 (/home/sky9/test/cargo-dist/axoproject)
│               └── dist v1.0.0-rc.1 (/home/sky9/test/cargo-dist/cargo-dist)
├── dist-schema v1.0.0-rc.1 (/home/sky9/test/cargo-dist/cargo-dist-schema)
│   └── dist v1.0.0-rc.1 (/home/sky9/test/cargo-dist/cargo-dist)
└── target-spec v3.1.0 (*)

After:

$ cargo tree --invert --package target-lexicon@0.12.16
target-lexicon v0.12.16
└── dist-schema v1.0.0-rc.1 (/home/sky9/test/cargo-dist/cargo-dist-schema)
    └── dist v1.0.0-rc.1 (/home/sky9/test/cargo-dist/cargo-dist)

$ cargo tree --invert --package target-lexicon@0.13.2
target-lexicon v0.13.2
├── cfg-expr v0.18.0
│   └── target-spec v3.4.2
│       └── guppy v0.17.17
│           └── axoproject v1.0.0-rc.1 (/home/sky9/test/cargo-dist/axoproject)
│               └── dist v1.0.0-rc.1 (/home/sky9/test/cargo-dist/cargo-dist)
└── target-spec v3.4.2 (*)
Output of running cargo update 
$ cargo update -v
    Updating crates.io index
     Locking 157 packages to latest compatible versions
    Updating anstream v0.6.14 -> v0.6.18
    Updating anstyle v1.0.8 -> v1.0.10
    Updating anstyle-parse v0.2.4 -> v0.2.6
    Updating anstyle-query v1.0.3 -> v1.1.2
    Updating anstyle-wincon v3.0.3 -> v3.0.7
    Updating autocfg v1.3.0 -> v1.4.0
   Unchanged backon v0.4.4 (latest: v1.4.0)
    Updating bitflags v2.5.0 -> v2.8.0
   Unchanged bitflags v1.3.2 (latest: v2.8.0)
    Updating bumpalo v3.16.0 -> v3.17.0
    Updating bytemuck v1.16.0 -> v1.21.0
    Updating bytes v1.6.0 -> v1.10.0
   Unchanged bzip2 v0.4.4 (latest: v0.5.1)
    Updating bzip2-sys v0.1.11+1.0.8 -> v0.1.12+1.0.8
    Updating cargo-platform v0.1.8 -> v0.1.9 (latest: v0.2.0)
      Adding cargo_metadata v0.19.1
   Unchanged cargo_metadata v0.18.1 (latest: v0.19.1)
    Updating cc v1.0.98 -> v1.2.15
    Updating cfg-expr v0.15.8 -> v0.18.0
    Updating chrono v0.4.38 -> v0.4.39
    Updating clap v4.5.28 -> v4.5.30
    Updating clap-cargo v0.14.0 -> v0.14.1 (latest: v0.15.2)
    Updating clap_builder v4.5.27 -> v4.5.30
   Unchanged color-backtrace v0.6.1 (latest: v0.7.0)
    Updating colorchoice v1.0.1 -> v1.0.3
   Unchanged constant_time_eq v0.1.5 (latest: v0.4.0)
    Updating core-foundation v0.9.4 -> v0.10.0
    Updating core-foundation-sys v0.8.6 -> v0.8.7
    Updating cpufeatures v0.2.12 -> v0.2.17
    Updating crossbeam-utils v0.8.20 -> v0.8.21
   Unchanged darling v0.14.4 (latest: v0.20.10)
   Unchanged darling_core v0.14.4 (latest: v0.20.10)
   Unchanged darling_macro v0.14.4 (latest: v0.20.10)
   Unchanged derive_builder v0.11.2 (latest: v0.20.2)
   Unchanged derive_builder_core v0.11.2 (latest: v0.20.2)
   Unchanged derive_builder_macro v0.11.2 (latest: v0.20.2)
    Updating dyn-clone v1.0.17 -> v1.0.18
    Updating either v1.12.0 -> v1.13.0
    Updating encoding_rs v0.8.34 -> v0.8.35
   Unchanged env_logger v0.10.2 (latest: v0.11.6)
    Updating equivalent v1.0.1 -> v1.0.2
    Updating errno v0.3.9 -> v0.3.10
    Updating fastrand v2.1.0 -> v2.3.0
    Updating filetime v0.2.23 -> v0.2.25
    Updating fixedbitset v0.4.2 -> v0.5.7
    Updating futures-channel v0.3.30 -> v0.3.31
    Updating futures-core v0.3.30 -> v0.3.31
    Updating futures-task v0.3.30 -> v0.3.31
    Updating futures-util v0.3.30 -> v0.3.31
   Unchanged generic-array v0.14.7 (latest: v1.2.0)
   Unchanged getrandom v0.2.15 (latest: v0.3.1)
   Unchanged goblin v0.8.2 (latest: v0.9.3)
    Updating guppy v0.17.5 -> v0.17.17
   Unchanged hashbrown v0.12.3 (latest: v0.15.2)
    Updating hermit-abi v0.3.9 -> v0.4.0
    Updating http v1.1.0 -> v1.2.0
    Updating http-body v1.0.0 -> v1.0.1
    Updating http-body-util v0.1.1 -> v0.1.2
    Updating httparse v1.8.0 -> v1.10.0
    Updating hyper v1.3.1 -> v1.6.0
    Updating hyper-rustls v0.27.2 -> v0.27.5
    Updating hyper-util v0.1.3 -> v0.1.10
    Updating iana-time-zone v0.1.60 -> v0.1.61
    Updating image v0.25.4 -> v0.25.5
    Updating indexmap v2.6.0 -> v2.7.1
   Unchanged indexmap v1.9.3 (latest: v2.7.1)
    Updating inout v0.1.3 -> v0.1.4
    Updating ipnet v2.9.0 -> v2.11.0
    Updating is-terminal v0.4.12 -> v0.4.15
    Updating is_terminal_polyfill v1.70.0 -> v1.70.1
    Updating itertools v0.12.1 -> v0.14.0
   Unchanged itertools v0.11.0 (latest: v0.14.0)
   Unchanged itertools v0.13.0 (latest: v0.14.0)
    Updating itoa v1.0.11 -> v1.0.14
    Updating jobserver v0.1.31 -> v0.1.32
    Updating js-sys v0.3.69 -> v0.3.77
      Adding libredox v0.1.3
   Unchanged libyml v0.0.4 (latest: v0.0.5)
    Updating linux-raw-sys v0.4.14 -> v0.4.15 (latest: v0.8.0)
    Updating litemap v0.7.3 -> v0.7.4
    Updating log v0.4.22 -> v0.4.26
   Unchanged log v0.3.9 (latest: v0.4.26)
    Updating memo-map v0.3.2 -> v0.3.3
   Unchanged miette v5.10.0 (latest: v7.5.0)
   Unchanged miette-derive v5.10.0 (latest: v7.5.0)
    Updating minijinja v2.6.0 -> v2.7.0
    Updating miniz_oxide v0.8.0 -> v0.8.5
    Updating mio v1.0.1 -> v1.0.3
   Unchanged nom v7.1.3 (latest: v8.0.0)
   Unchanged nu-ansi-term v0.46.0 (latest: v0.50.1)
    Updating object v0.36.5 -> v0.36.7
    Updating once_cell v1.20.2 -> v1.20.3
    Updating openssl-probe v0.1.5 -> v0.1.6
    Updating owo-colors v4.0.0 -> v4.2.0
    Updating parking_lot v0.12.2 -> v0.12.3
   Unchanged password-hash v0.4.2 (latest: v0.5.0)
   Unchanged pbkdf2 v0.11.0 (latest: v0.12.2)
    Updating petgraph v0.6.5 -> v0.7.1
    Updating pin-project v1.1.5 -> v1.1.9
    Updating pin-project-internal v1.1.5 -> v1.1.9
    Updating pin-project-lite v0.2.14 -> v0.2.16
    Updating pkg-config v0.3.30 -> v0.3.31
    Updating ppv-lite86 v0.2.17 -> v0.2.20
    Updating proc-macro2 v1.0.83 -> v1.0.93
   Unchanged quick-error v1.2.3 (latest: v2.0.1)
    Updating quinn v0.11.2 -> v0.11.6
    Updating quinn-proto v0.11.8 -> v0.11.9
    Updating quinn-udp v0.5.2 -> v0.5.10
    Updating quote v1.0.36 -> v1.0.38
   Unchanged rand v0.8.5 (latest: v0.9.0)
   Unchanged rand_chacha v0.3.1 (latest: v0.9.0)
   Unchanged rand_core v0.6.4 (latest: v0.9.2)
    Removing redox_syscall v0.4.1
    Removing redox_syscall v0.5.1
      Adding redox_syscall v0.5.9
    Updating regex v1.10.4 -> v1.11.1
    Updating regex-automata v0.4.6 -> v0.4.9
    Updating regex-syntax v0.8.3 -> v0.8.5
    Updating reqwest v0.12.5 -> v0.12.12
    Updating ring v0.17.8 -> v0.17.11
    Removing rustc-hash v1.1.0
    Removing rustc-hash v2.0.0
      Adding rustc-hash v2.1.1
    Updating rustix v0.38.34 -> v0.38.44
    Updating rustls v0.23.10 -> v0.23.23
    Updating rustls-native-certs v0.7.1 -> v0.8.1
    Updating rustls-pemfile v2.1.2 -> v2.2.0
    Updating rustls-pki-types v1.7.0 -> v1.11.0
    Updating rustls-webpki v0.102.4 -> v0.102.8
      Adding rustversion v1.0.19
    Updating ryu v1.0.18 -> v1.0.19
    Updating schannel v0.1.23 -> v0.1.27
    Updating security-framework v2.11.0 -> v3.2.0
    Updating security-framework-sys v2.11.0 -> v2.14.0
    Updating self_cell v1.0.4 -> v1.1.0
    Updating serde v1.0.217 -> v1.0.218
    Updating serde_derive v1.0.217 -> v1.0.218
    Updating serde_json v1.0.138 -> v1.0.139
   Unchanged serde_yml v0.0.11 (latest: v0.0.12)
      Adding shlex v1.3.0
    Updating smallvec v1.13.2 -> v1.14.0
    Updating socket2 v0.5.7 -> v0.5.8
    Removing spin v0.9.8
   Unchanged strsim v0.10.0 (latest: v0.11.1)
    Updating subtle v2.5.0 -> v2.6.1
    Updating supports-color v3.0.0 -> v3.0.2
    Updating supports-hyperlinks v3.0.0 -> v3.1.0
    Updating syn v2.0.87 -> v2.0.98
   Unchanged syn v1.0.109 (latest: v2.0.98)
    Updating sync_wrapper v1.0.1 -> v1.0.2
    Updating tar v0.4.43 -> v0.4.44
      Adding target-lexicon v0.13.2
   Unchanged target-lexicon v0.12.16 (latest: v0.13.2)
    Updating target-spec v3.1.0 -> v3.4.2
    Updating tempfile v3.10.1 -> v3.17.1
   Unchanged thiserror v1.0.69 (latest: v2.0.11)
   Unchanged thiserror-impl v1.0.69 (latest: v2.0.11)
    Updating time v0.3.36 -> v0.3.37
    Updating time-macros v0.2.18 -> v0.2.19
   Unchanged tinystr v0.7.6 (latest: v0.8.0)
    Updating tinyvec v1.6.0 -> v1.8.1
    Updating tokio-rustls v0.26.0 -> v0.26.1
    Updating toml v0.8.13 -> v0.8.20
    Updating toml_edit v0.22.22 -> v0.22.24
    Updating tower v0.4.13 -> v0.5.2
    Updating tower-layer v0.3.2 -> v0.3.3
    Updating tower-service v0.3.2 -> v0.3.3
    Updating tracing-subscriber v0.3.18 -> v0.3.19
   Unchanged typed-arena v1.7.0 (latest: v2.0.2)
    Updating typenum v1.17.0 -> v1.18.0
    Updating unicode-ident v1.0.12 -> v1.0.17
    Updating unicode-segmentation v1.11.0 -> v1.12.0
    Updating unicode-width v0.1.12 -> v0.1.14 (latest: v0.2.0)
    Updating utf8parse v0.2.1 -> v0.2.2
    Updating uuid v1.13.1 -> v1.14.0
    Updating valuable v0.1.0 -> v0.1.1
    Updating version_check v0.9.4 -> v0.9.5
   Unchanged wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.14.1+wasi-0.2.3)
   Unchanged wasi v0.13.3+wasi-0.2.2 (latest: v0.14.1+wasi-0.2.3)
    Updating wasm-bindgen v0.2.92 -> v0.2.100
    Updating wasm-bindgen-backend v0.2.92 -> v0.2.100
    Updating wasm-bindgen-futures v0.4.42 -> v0.4.50
    Updating wasm-bindgen-macro v0.2.92 -> v0.2.100
    Updating wasm-bindgen-macro-support v0.2.92 -> v0.2.100
    Updating wasm-bindgen-shared v0.2.92 -> v0.2.100
    Updating web-sys v0.3.69 -> v0.3.77
      Adding web-time v1.1.0
    Updating webpki-roots v0.26.1 -> v0.26.8
    Updating winapi-util v0.1.8 -> v0.1.9
   Unchanged windows v0.57.0 (latest: v0.60.0)
   Unchanged windows-core v0.52.0 (latest: v0.60.1)
   Unchanged windows-core v0.57.0 (latest: v0.60.1)
   Unchanged windows-implement v0.57.0 (latest: v0.59.0)
   Unchanged windows-interface v0.57.0 (latest: v0.59.0)
      Adding windows-registry v0.2.0 (latest: v0.5.0)
      Adding windows-result v0.2.0 (latest: v0.3.1)
   Unchanged windows-result v0.1.2 (latest: v0.3.1)
      Adding windows-strings v0.1.0 (latest: v0.3.1)
    Removing windows-sys v0.48.0
   Unchanged windows-sys v0.52.0 (latest: v0.59.0)
    Removing windows-targets v0.48.5
   Unchanged windows-targets v0.52.6 (latest: v0.53.0)
    Removing windows_aarch64_gnullvm v0.48.5
   Unchanged windows_aarch64_gnullvm v0.52.6 (latest: v0.53.0)
    Removing windows_aarch64_msvc v0.48.5
   Unchanged windows_aarch64_msvc v0.52.6 (latest: v0.53.0)
    Removing windows_i686_gnu v0.48.5
   Unchanged windows_i686_gnu v0.52.6 (latest: v0.53.0)
   Unchanged windows_i686_gnullvm v0.52.6 (latest: v0.53.0)
    Removing windows_i686_msvc v0.48.5
   Unchanged windows_i686_msvc v0.52.6 (latest: v0.53.0)
    Removing windows_x86_64_gnu v0.48.5
   Unchanged windows_x86_64_gnu v0.52.6 (latest: v0.53.0)
    Removing windows_x86_64_gnullvm v0.48.5
   Unchanged windows_x86_64_gnullvm v0.52.6 (latest: v0.53.0)
    Removing windows_x86_64_msvc v0.48.5
   Unchanged windows_x86_64_msvc v0.52.6 (latest: v0.53.0)
    Updating winnow v0.6.20 -> v0.7.3
    Removing winreg v0.52.0
   Unchanged wit-bindgen-rt v0.33.0 (latest: v0.39.0)
   Unchanged writeable v0.5.5 (latest: v0.6.0)
    Updating xattr v1.3.1 -> v1.4.0
    Updating yoke v0.7.4 -> v0.7.5
    Updating yoke-derive v0.7.4 -> v0.7.5
    Updating zerocopy v0.7.34 -> v0.7.35 (latest: v0.8.20)
    Updating zerocopy-derive v0.7.34 -> v0.7.35 (latest: v0.8.20)
    Updating zerofrom v0.1.4 -> v0.1.5
    Updating zerofrom-derive v0.1.4 -> v0.1.5
    Updating zeroize v1.7.0 -> v1.8.1
   Unchanged zerovec v0.10.4 (latest: v0.11.0)
   Unchanged zerovec-derive v0.10.3 (latest: v0.11.0)
   Unchanged zip v0.6.6 (latest: v2.2.2)
    Updating zstd v0.13.1 -> v0.13.3
   Unchanged zstd v0.11.2+zstd.1.5.2 (latest: v0.13.3)
    Updating zstd-safe v7.1.0 -> v7.2.3
   Unchanged zstd-safe v5.0.2+zstd.1.5.2 (latest: v7.2.3)
    Updating zstd-sys v2.0.10+zstd.1.5.6 -> v2.0.14+zstd.1.5.7
note: to see how you depend on a package, run `cargo tree --invert --package <dep>@<ver>`
@rwygand
Copy link

rwygand commented Feb 25, 2025

I'm also seeing this behavior: it's causing my CI runs to fail.

@ahl
Copy link

ahl commented Feb 25, 2025

Also seeing this.

@CramBL
Copy link
Contributor

CramBL commented Mar 2, 2025

I'm also seeing this behavior: it's causing my CI runs to fail.

For stable installs you should always use the --locked option.

@Sky9x
Copy link
Author

Sky9x commented Mar 3, 2025

I'm also seeing this behavior: it's causing my CI runs to fail.

For stable installs you should always use the --locked option.

Unlocked installs are the default because it allows semver compatible dependency upgrades (for bug fixes etc). Cargo still publishes lockfiles to ensure reproducible builds and in case dependencies break (ie. exactly this situation). For CI builds it is a good idea to do locked installs (or use cargo binstall to avoid building from source every time).

Regardless, a broken unlocked build indicates a dependency made a breaking change, a semver violation. I filed this issue because the violation should be tracked down. Saying "just do a locked install" avoids the underlying problem and does nothing to prevent it from happening again.

https://doc.rust-lang.org/cargo/commands/cargo-install.html#dealing-with-the-lockfile

@CramBL
Copy link
Contributor

CramBL commented Mar 3, 2025

I'm also seeing this behavior: it's causing my CI runs to fail.

For stable installs you should always use the --locked option.

Unlocked installs are the default because it allows semver compatible dependency upgrades (for bug fixes etc). Cargo still publishes lockfiles to ensure reproducible builds and in case dependencies break (ie. exactly this situation). For CI builds it is a good idea to do locked installs (or use cargo binstall to avoid building from source every time).

Regardless, a broken unlocked build indicates a dependency made a breaking change, a semver violation. I filed this issue because the violation should be tracked down. Saying "just do a locked install" avoids the underlying problem and does nothing to prevent it from happening again.

doc.rust-lang.org/cargo/commands/cargo-install.html#dealing-with-the-lockfile

I agree, I was specifically responding to the post about it breaking CI.

@AnotherDaniel
Copy link

I've got this problem as well - maybe I'm obtuse, but is there a workaround that I missed?

@CramBL
Copy link
Contributor

CramBL commented Mar 11, 2025

I've got this problem as well - maybe I'm obtuse, but is there a workaround that I missed?

cargo install cargo-dist@0.28.0 --locked

@rwygand
Copy link

rwygand commented Mar 11, 2025

That definitely solved my CI issue.

@AnotherDaniel
Copy link

I've got this problem as well - maybe I'm obtuse, but is there a workaround that I missed?

cargo install cargo-dist@0.28.0 --locked

Thank you, that works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rwygand @ahl @AnotherDaniel @CramBL @Sky9x