Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use giget v2 #85

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

chore: use giget v2 #85

wants to merge 3 commits into from

Conversation

ryuapp
Copy link
Contributor

@ryuapp ryuapp commented Feb 26, 2025

Fix #51
giget v2 patches internal library and fixes the bug in Bun.

@yusukebe
Copy link
Member

Hi @ryuapp

Thank you for the PR. The CI is failing. Can you correct it?

@ryuapp
Copy link
Contributor Author

ryuapp commented Feb 27, 2025

Github Actions was not working just in time, so I think that's the cause. I'll check it later.
https://www.githubstatus.com/incidents/2lxm4wb8wy3r

@yusukebe
Copy link
Member

Hi @ryuapp

For your information. I tried to test this branch on my machine. But it fails.

CleanShot 2025-02-28 at 14 45 24@2x

@ryuapp
Copy link
Contributor Author

ryuapp commented Feb 28, 2025

@yusukebe
Thanks for your investigation. Since v2 has become an esm-only package, that may become a problem.
Once the tests is passed, I'll mention you again.

@ryuapp ryuapp marked this pull request as draft February 28, 2025 06:03
@yusukebe
Copy link
Member

@ryuapp

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bun create hono on Windows can't clone templates without Node.js
2 participants