[WEB-3286] fix: allow admins to delete other admins views

[sangeethailango]

Description

This PR will allow admins to delete a view created by other admins

Summary by CodeRabbit

• Refactor
  • Adjusted deletion permissions to restrict this action to administrators only, enhancing overall security and ensuring that only authorized users can perform deletions.

[makeplane]

Pull Request Linked with Plane Issues

• [WEB-3286] "You dont have the required permission " is displayed when admin tries to delete views created by other admin user

Comment Automatically Generated by Plane

[coderabbitai]

Walkthrough

This change updates the destroy method in the WorkspaceViewViewSet class. The permission decorator is modified to restrict deletion operations to users with the ROLE.ADMIN role only, replacing the previous implementation that allowed any user to attempt deletion. The method retains existing checks for workspace membership and ownership, while the response handling for unauthorized deletion attempts remains unchanged.

Changes

File	Change Summary
apiserver/…/views/view/base.py	Updated the destroy method's permission decorator in WorkspaceViewViewSet: replaced @allow_permission(allowed_roles=[], level="WORKSPACE", creator=True, model=IssueView) with @allow_permission(allowed_roles=[ROLE.ADMIN], level="WORKSPACE", creator=True, model=IssueView)

Sequence Diagram(s)

Loading

sequenceDiagram
    participant User
    participant WorkspaceView as "WorkspaceViewViewSet"
    participant PermChecker as "Permission Decorator"
    participant DB as "Database"

    User->>WorkspaceView: Request destroy(slug, pk)
    WorkspaceView->>PermChecker: Validate permission (ROLE.ADMIN)
    PermChecker-->>WorkspaceView: Permission granted/denied
    alt Permission Granted
        WorkspaceView->>DB: Delete IssueView instance
        DB-->>WorkspaceView: Deletion confirmation
        WorkspaceView-->>User: Return success response
    else Permission Denied
        WorkspaceView-->>User: Return access denied response
    end

Possibly related PRs

• [WEB-2401] chore: worklog enhancements #5982: The changes in the main PR, which restrict the destroy method to only allow users with the ADMIN role, are related to the retrieved PR's enhancements that also enforce user role checks for adding time logs, specifically allowing only admins or assignees to perform certain actions.
• [WEB-2498] fix: workspace archives and setting validation #5654: The changes in the main PR, which restrict the destroy method's access to only users with the ADMIN role, are directly related to the modifications in the retrieved PR that also limit permissions to the ADMIN role for workspace-level access in the SidebarWorkspaceMenu component.
• [WEB-3436] fix: work item delete permission and header translation #6654: The changes in the main PR, which modify the permission logic for the destroy method in the WorkspaceViewViewSet class, are related to the changes in the retrieved PR that also address work item deletion permissions, indicating a shared focus on access control for deletion operations.

Suggested labels

🐛bug, 🧹chore

Suggested reviewers

• sriramveeraghanta
• SatishGandham

Poem

In a burrow deep, I write with glee,
Changing codes as swift as can be.
New permissions guard with care,
Only admins may dare.
Hoppin' through code, I cheer today! 🐇🌟
Changes secure the maze where bugs stray.

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)

• We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
  - To enable this feature, set early_access to true under in the settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b778b3c and 3a4dd7e.

📒 Files selected for processing (1)

• apiserver/plane/app/views/view/base.py (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• apiserver/plane/app/views/view/base.py

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Analyze (javascript)
• GitHub Check: Analyze (python)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.