feat(completer): Added completion for --features flag
#15309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-cli
|
@epage suggestion will be appreciated on how can i improve this like should i include some description ? or something like that, as i have not discussed with yu earlier and pick directly from the parent issue |
epage
reviewed
Mar 14, 2025
Comment on lines
+1127
to
+1133
| let current_dir = std::env::current_dir()?; | ||
|
|
||
| let current_pkg = ws | ||
| .members() | ||
| .find(|pkg| current_dir.starts_with(pkg.root())) | ||
| .or_else(|| ws.members().next()) | ||
| .cloned(); |
There was a problem hiding this comment.
For --bin [TAB], we complete for any package in the workspace in case --package is used
epage
reviewed
Mar 14, 2025
Comment on lines
+1142
to
+1146
| for dep in package.dependencies() { | ||
| if dep.is_optional() { | ||
| features.insert(dep.name_in_toml().to_string()); | ||
| } | ||
| } |
There was a problem hiding this comment.
Are these in the package's summary?
epage
reviewed
Mar 14, 2025
Comment on lines
+1183
to
+1186
| Ok(features | ||
| .into_iter() | ||
| .map(|name| clap_complete::CompletionCandidate::new(name)) | ||
| .collect()) |
There was a problem hiding this comment.
Should we sort or de-duplicate?
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
This attempts to complete the autocompleter for
cargo build --features <TAB>,cargo run --features <TAB>It loads all the features that are there in the profile section of Cargo.toml
Related to #14520
How should we test and review this PR?
by running
cargo build --features <TAB>,cargo run --features <TAB>