-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not pass cdylib link args to test #15317
base: master
Are you sure you want to change the base?
Conversation
4b8a167
to
1609e02
Compare
r? ehuss Since you have more of the background on this |
Thanks! I'm a little uncertain about changing |
This comment has been minimized.
This comment has been minimized.
I initially assumed they were different based on intuition. I recalled a case where a binary was compiled for a bare-metal target, and I used custom test frameworks to run tests in the same environment. If the current behavior changes, similar use cases could break. So, I reverted to the previous behavior for |
fixes #12663