fix runtime errors in colocated python dataloader #1819
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Fix: Resolve runtime errors in colocated TFDS dataloader
Description
fixes:
_tfds_data_processing.py
:tfds.builder
now correctly uses thedataset_path
variable, which is needed for tfds.RemoteIterator
has been updated to passglobal_shape
as argument, fixing an interface mismatch.multihost_dataloading.py
:put_to_tpu_devices
function now correctly returns the array after it has been placed on the TPU device. Otherwise the iterator would have empty data.RemoteIterator
is now more informative, including a test output to aid in debugging and validation.Tests
This patch was used in the last round of scale tests, validated up to 4 slice scale.
Checklist
Before submitting this PR, please make sure (put X in square brackets):