-
Notifications
You must be signed in to change notification settings - Fork 361
pyconfig → pydantic #1836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
SamuelMarks
wants to merge
15
commits into
AI-Hypercomputer:main
Choose a base branch
from
SamuelMarks:pydantic
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
pyconfig → pydantic #1836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d config (over pyconfig) ; [*] Replace pyconfig with pydantic
…eline/input_pipeline_interface.py,MaxText/tests/inference/page_manager_test.py,MaxText/tests/{maxengine_test,pipeline_parallelism_test}.py] Improve config percolation
…/loader.py] Format (`pyink`)
…just this one file to see if tests pass on CI
…ope_type` in class var `overrides`
…revert to check CI
…onfigs/utils.py] Add `merge_pydantic_models` ; [MaxText/tests/attention_test.py] Carefully start migration to new `class` style config
…onfig usage to match new pydantic `class`es
…ate new config class thoughout ; [MaxText/configs/types_g.py] Ensure type defaults match attention expectations ; [MaxText/configs/utils.py] `pyink`
…te new config format throughout attention_test & attentions
…, as it's not in image yet) ; [MaxText/configs/{types_g,utils}.py] Add docstrings ; linting ; [MaxText/tests/attention_test.py] Linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Background
MaxText is currently engineered around pyconfig. Pyconfig—https://pypi.org/project/pyconfig/—was last updated in 2017 and has 20k monthly downloads.
Pydantic—https://pypi.org/project/pydantic/—is constantly updated and has hundreds of millions of monthly downloads.
– https://docs.pydantic.dev
Summary
The TL;DR version is:
--help
and GUIs and generate SQL models (SQLAlchemy) as desiredMigration
Proposed changes to the MaxText codebase:
from_pyconfig_to_pydantic
types.py
, ortypes.py
per config occurrence (e.g., one per module if each module has a different config)Technical implementation notes
Consistency
As part of migrating the codebase across to the new configuration format various small changes were made to improve consistency. These include:
self.cfg
→self.config
:Tests
Tested the change on your CI.
Checklist
Before submitting this PR, please make sure (put X in square brackets):