Skip to content

[Profiler] Use ringbuffer with timer create #7066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

[Profiler] Use ringbuffer with timer create #7066

wants to merge 11 commits into from

Conversation

gleocadie
Copy link
Collaborator

@gleocadie gleocadie commented Jun 5, 2025 •
edited
Loading

Summary of changes

https://datadoghq.atlassian.net/browse/PROF-11985

Reason for change

Implementation details

Test coverage

Other details

@github-actions github-actions bot added the area:profiler Issues related to the continous-profiler label Jun 5, 2025
@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7066) - mean (73ms)  : 70, 77
     .   : milestone, 73,
    master - mean (72ms)  : 69, 75
     .   : milestone, 72,

    section CallTarget+Inlining+NGEN
    This PR (7066) - mean (1,061ms)  : 1035, 1086
     .   : milestone, 1061,
    master - mean (1,050ms)  : 1022, 1078
     .   : milestone, 1050,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7066) - mean (111ms)  : 107, 115
     .   : milestone, 111,
    master - mean (110ms)  : 106, 114
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (7066) - mean (739ms)  : 714, 765
     .   : milestone, 739,
    master - mean (720ms)  : 704, 736
     .   : milestone, 720,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7066) - mean (96ms)  : 93, 100
     .   : milestone, 96,
    master - mean (94ms)  : 92, 97
     .   : milestone, 94,

    section CallTarget+Inlining+NGEN
    This PR (7066) - mean (700ms)  : 675, 726
     .   : milestone, 700,
    master - mean (694ms)  : 673, 714
     .   : milestone, 694,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7066) - mean (189ms)  : 186, 193
     .   : milestone, 189,
    master - mean (190ms)  : 186, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (7066) - mean (1,162ms)  : 1145, 1179
     .   : milestone, 1162,
    master - mean (1,165ms)  : 1151, 1179
     .   : milestone, 1165,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7066) - mean (269ms)  : 264, 273
     .   : milestone, 269,
    master - mean (269ms)  : 266, 273
     .   : milestone, 269,

    section CallTarget+Inlining+NGEN
    This PR (7066) - mean (931ms)  : 914, 947
     .   : milestone, 931,
    master - mean (933ms)  : 919, 947
     .   : milestone, 933,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7066) - mean (262ms)  : 258, 265
     .   : milestone, 262,
    master - mean (262ms)  : 258, 266
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (7066) - mean (922ms)  : 909, 936
     .   : milestone, 922,
    master - mean (930ms)  : 916, 944
     .   : milestone, 930,
Loading

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jun 5, 2025 •
edited
Loading

Datadog Report

All test runs 26a5d67 🔗

✅ 2 Total Test Services: 0 Failed, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Test Service View
dd-trace-dotnet 0 0 0 250664 2865 17h 6m 47.12s Link
exploration_tests 0 0 0 22085 3 2m 27.4s Link

@pr-commenter
Copy link

pr-commenter bot commented Jun 5, 2025 •
edited
Loading

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7066 compared to master:

  • 3 benchmarks are slower, with geometric mean 1.518
  • 41 benchmarks have fewer allocations
  • 4 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7066

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 6.09 KB 6.04 KB -48 B -0.79%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1 5.75 KB 5.7 KB -55 B -0.96%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net6.0 5.58 KB 5.49 KB -83 B -1.49%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 11.2μs 59.7ns 322ns 0 0 0 5.58 KB
master StartStopWithChild netcoreapp3.1 14.1μs 67.5ns 286ns 0 0 0 5.75 KB
master StartStopWithChild net472 22.1μs 119ns 651ns 1.03 0.411 0.103 6.09 KB
#7066 StartStopWithChild net6.0 10.4μs 57ns 361ns 0 0 0 5.49 KB
#7066 StartStopWithChild netcoreapp3.1 13.4μs 62.3ns 241ns 0 0 0 5.7 KB
#7066 StartStopWithChild net472 21.9μs 111ns 521ns 1.05 0.35 0.117 6.04 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7066

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 3.33 KB 3.31 KB -23 B -0.69%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 927μs 26.6ns 103ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.04ms 404ns 1.56μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.25ms 357ns 1.38μs 0 0 0 3.33 KB
#7066 WriteAndFlushEnrichedTraces net6.0 927μs 134ns 502ns 0 0 0 2.71 KB
#7066 WriteAndFlushEnrichedTraces netcoreapp3.1 1.02ms 46.1ns 166ns 0 0 0 2.7 KB
#7066 WriteAndFlushEnrichedTraces net472 1.21ms 35.9ns 129ns 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7066

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody‑net472 236.35 KB 239.64 KB 3.28 KB 1.39%
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody‑net472 239.87 KB 243.15 KB 3.28 KB 1.37%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 331μs 1.76μs 8.42μs 0 0 0 197.06 KB
master AllCycleSimpleBody netcoreapp3.1 510μs 1.45μs 5.61μs 0 0 0 204.77 KB
master AllCycleSimpleBody net472 436μs 119ns 460ns 36.6 2.16 0 236.35 KB
master AllCycleMoreComplexBody net6.0 338μs 1.76μs 8.8μs 0 0 0 200.56 KB
master AllCycleMoreComplexBody netcoreapp3.1 495μs 987ns 3.56μs 0 0 0 208.18 KB
master AllCycleMoreComplexBody net472 446μs 106ns 412ns 36.6 2.16 0 239.87 KB
master ObjectExtractorSimpleBody net6.0 311ns 1.77ns 12.3ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 409ns 1.93ns 8.2ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 303ns 0.175ns 0.676ns 0.0442 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.52μs 29.5ns 110ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.76μs 36.2ns 140ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.66μs 0.89ns 3.33ns 0.599 0 0 3.8 KB
#7066 AllCycleSimpleBody net6.0 335μs 797ns 3.08μs 0 0 0 197.59 KB
#7066 AllCycleSimpleBody netcoreapp3.1 474μs 941ns 3.65μs 0 0 0 205.35 KB
#7066 AllCycleSimpleBody net472 441μs 129ns 482ns 36.6 2.16 0 239.64 KB
#7066 AllCycleMoreComplexBody net6.0 337μs 111ns 383ns 0 0 0 201.1 KB
#7066 AllCycleMoreComplexBody netcoreapp3.1 515μs 2.02μs 7.84μs 0 0 0 208.77 KB
#7066 AllCycleMoreComplexBody net472 455μs 205ns 793ns 37.9 2.23 0 243.15 KB
#7066 ObjectExtractorSimpleBody net6.0 322ns 1.65ns 7.4ns 0 0 0 280 B
#7066 ObjectExtractorSimpleBody netcoreapp3.1 406ns 2.12ns 9.94ns 0 0 0 272 B
#7066 ObjectExtractorSimpleBody net472 304ns 0.0608ns 0.235ns 0.0432 0 0 281 B
#7066 ObjectExtractorMoreComplexBody net6.0 6.35μs 30.6ns 126ns 0 0 0 3.78 KB
#7066 ObjectExtractorMoreComplexBody netcoreapp3.1 7.86μs 33ns 128ns 0 0 0 3.69 KB
#7066 ObjectExtractorMoreComplexBody net472 6.92μs 8.07ns 31.3ns 0.589 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7066

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs‑net6.0 2.16 KB 2.15 KB -11 B -0.51%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 73.3μs 263ns 984ns 0 0 0 32.41 KB
master EncodeArgs netcoreapp3.1 95.7μs 36.2ns 130ns 0 0 0 32.4 KB
master EncodeArgs net472 107μs 17.6ns 65.8ns 4.82 0 0 32.51 KB
master EncodeLegacyArgs net6.0 143μs 122ns 472ns 0 0 0 2.16 KB
master EncodeLegacyArgs netcoreapp3.1 197μs 42.5ns 147ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 261μs 66.8ns 250ns 0 0 0 2.16 KB
#7066 EncodeArgs net6.0 73.4μs 163ns 632ns 0 0 0 32.4 KB
#7066 EncodeArgs netcoreapp3.1 94.9μs 298ns 1.15μs 0 0 0 32.4 KB
#7066 EncodeArgs net472 104μs 13.3ns 51.6ns 4.69 0 0 32.51 KB
#7066 EncodeLegacyArgs net6.0 146μs 27.7ns 104ns 0 0 0 2.15 KB
#7066 EncodeLegacyArgs netcoreapp3.1 198μs 106ns 366ns 0 0 0 2.14 KB
#7066 EncodeLegacyArgs net472 263μs 45ns 168ns 0 0 0 2.16 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 271μs 133ns 499ns 0 0 0 4.55 KB
master RunWafRealisticBenchmark netcoreapp3.1 294μs 264ns 989ns 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 307μs 38.1ns 147ns 0 0 0 4.66 KB
master RunWafRealisticBenchmarkWithAttack net6.0 181μs 80.1ns 300ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 198μs 104ns 404ns 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 207μs 45.3ns 169ns 0 0 0 2.28 KB
#7066 RunWafRealisticBenchmark net6.0 270μs 69.6ns 251ns 0 0 0 4.55 KB
#7066 RunWafRealisticBenchmark netcoreapp3.1 290μs 23.5ns 87.9ns 0 0 0 4.48 KB
#7066 RunWafRealisticBenchmark net472 309μs 115ns 447ns 0 0 0 4.66 KB
#7066 RunWafRealisticBenchmarkWithAttack net6.0 183μs 49.7ns 186ns 0 0 0 2.24 KB
#7066 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 197μs 441ns 1.71μs 0 0 0 2.22 KB
#7066 RunWafRealisticBenchmarkWithAttack net472 208μs 57.6ns 223ns 0 0 0 2.29 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.1μs 29ns 104ns 0 0 0 14.53 KB
master SendRequest netcoreapp3.1 69.9μs 118ns 440ns 0 0 0 17.42 KB
master SendRequest net472 0.0171ns 0.00147ns 0.00551ns 0 0 0 0 b
#7066 SendRequest net6.0 61.6μs 56ns 210ns 0 0 0 14.52 KB
#7066 SendRequest netcoreapp3.1 70.8μs 86.2ns 298ns 0 0 0 17.43 KB
#7066 SendRequest net472 0.00102ns 0.000739ns 0.00286ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #7066

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 1.234 631,437.50 779,288.65 several?

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 645μs 512ns 1.98μs 0 0 0 41.73 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 631μs 1.67μs 6.67μs 0 0 0 41.89 KB
master WriteAndFlushEnrichedTraces net472 923μs 1.93μs 7.2μs 4.46 0 0 55.75 KB
#7066 WriteAndFlushEnrichedTraces net6.0 621μs 532ns 1.92μs 0 0 0 41.76 KB
#7066 WriteAndFlushEnrichedTraces netcoreapp3.1 730μs 7.22μs 72.2μs 0 0 0 41.88 KB
#7066 WriteAndFlushEnrichedTraces net472 962μs 4.19μs 16.2μs 4.81 0 0 55.94 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7066

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0 1.03 KB 1.02 KB -8 B -0.78%
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑netcoreapp3.1 1.02 KB 1.02 KB -8 B -0.78%
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net472 995 B 987 B -8 B -0.80%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.99μs 10.2ns 46.8ns 0 0 0 1.03 KB
master ExecuteNonQuery netcoreapp3.1 2.53μs 3.43ns 13.3ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.7μs 2.41ns 9.34ns 0.147 0.0134 0 995 B
#7066 ExecuteNonQuery net6.0 1.98μs 1.99ns 7.44ns 0 0 0 1.02 KB
#7066 ExecuteNonQuery netcoreapp3.1 2.69μs 5.01ns 18.8ns 0 0 0 1.02 KB
#7066 ExecuteNonQuery net472 2.85μs 13.8ns 55.2ns 0.153 0.0139 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7066

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net472 1.11 KB 1.1 KB -8 B -0.72%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑netcoreapp3.1 1.09 KB 1.08 KB -8 B -0.74%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net472 1.05 KB 1.04 KB -8 B -0.76%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0 1.04 KB 1.03 KB -8 B -0.77%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑netcoreapp3.1 1.04 KB 1.03 KB -8 B -0.77%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0 1.02 KB 1.01 KB -8 B -0.79%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.83μs 5.85ns 22.7ns 0 0 0 1.04 KB
master CallElasticsearch netcoreapp3.1 2.3μs 11.8ns 56.6ns 0 0 0 1.04 KB
master CallElasticsearch net472 3.55μs 3.05ns 11.8ns 0.159 0 0 1.05 KB
master CallElasticsearchAsync net6.0 1.81μs 3.89ns 14.5ns 0 0 0 1.02 KB
master CallElasticsearchAsync netcoreapp3.1 2.35μs 7.26ns 28.1ns 0 0 0 1.09 KB
master CallElasticsearchAsync net472 3.84μs 3.19ns 12.4ns 0.169 0 0 1.11 KB
#7066 CallElasticsearch net6.0 1.78μs 8.16ns 31.6ns 0 0 0 1.03 KB
#7066 CallElasticsearch netcoreapp3.1 2.29μs 7.69ns 29.8ns 0 0 0 1.03 KB
#7066 CallElasticsearch net472 3.63μs 2.74ns 10.2ns 0.162 0 0 1.04 KB
#7066 CallElasticsearchAsync net6.0 1.85μs 5.53ns 21.4ns 0 0 0 1.01 KB
#7066 CallElasticsearchAsync netcoreapp3.1 2.41μs 12ns 53.9ns 0 0 0 1.08 KB
#7066 CallElasticsearchAsync net472 3.77μs 4.36ns 16.3ns 0.17 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7066

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0 960 B 952 B -8 B -0.83%
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑netcoreapp3.1 960 B 952 B -8 B -0.83%
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net472 923 B 915 B -8 B -0.87%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.78μs 9.27ns 43.5ns 0 0 0 960 B
master ExecuteAsync netcoreapp3.1 2.29μs 7.45ns 25.8ns 0 0 0 960 B
master ExecuteAsync net472 2.58μs 1.78ns 6.88ns 0.143 0 0 923 B
#7066 ExecuteAsync net6.0 1.87μs 9.52ns 41.5ns 0 0 0 952 B
#7066 ExecuteAsync netcoreapp3.1 2.36μs 7.67ns 29.7ns 0 0 0 952 B
#7066 ExecuteAsync net472 2.53μs 2.23ns 8.04ns 0.14 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 7.1μs 10.4ns 39ns 0 0 0 2.37 KB
master SendAsync netcoreapp3.1 8.69μs 14.1ns 54.6ns 0 0 0 2.9 KB
master SendAsync net472 12.5μs 10.3ns 38.5ns 0.498 0 0 3.19 KB
#7066 SendAsync net6.0 6.97μs 5.72ns 22.2ns 0 0 0 2.36 KB
#7066 SendAsync netcoreapp3.1 8.53μs 17.5ns 67.7ns 0 0 0 2.9 KB
#7066 SendAsync net472 12.2μs 8.12ns 31.5ns 0.487 0 0 3.18 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #7066

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 2.334 458,300.00 1,069,700.00
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 1.215 413,700.00 502,700.00

More allocations ⚠️ in #7066

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 259.96 KB 312.97 KB 53.01 KB 20.39%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 42.64 KB 43.62 KB 976 B 2.29%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 44.6μs 212ns 1.6μs 0 0 0 43.83 KB
master StringConcatBenchmark netcoreapp3.1 47.2μs 224ns 838ns 0 0 0 42.64 KB
master StringConcatBenchmark net472 56.8μs 259ns 968ns 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 458μs 1.08μs 3.89μs 0 0 0 259.96 KB
master StringConcatAspectBenchmark netcoreapp3.1 447μs 6.44μs 63.7μs 0 0 0 274.93 KB
master StringConcatAspectBenchmark net472 410μs 2.07μs 9.27μs 0 0 0 286.72 KB
#7066 StringConcatBenchmark net6.0 42.6μs 218ns 1.33μs 0 0 0 43.86 KB
#7066 StringConcatBenchmark netcoreapp3.1 47.1μs 251ns 1.2μs 0 0 0 43.62 KB
#7066 StringConcatBenchmark net472 57.6μs 239ns 896ns 0 0 0 57.34 KB
#7066 StringConcatAspectBenchmark net6.0 1.07ms 2.28μs 7.91μs 0 0 0 312.97 KB
#7066 StringConcatAspectBenchmark netcoreapp3.1 502μs 1.67μs 6.01μs 0 0 0 274.12 KB
#7066 StringConcatAspectBenchmark net472 401μs 1.55μs 5.8μs 0 0 0 286.72 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7066

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑netcoreapp3.1 1.76 KB 1.71 KB -54 B -3.07%
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0 1.76 KB 1.7 KB -56 B -3.18%
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net472 1.69 KB 1.64 KB -56 B -3.31%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.63μs 2.6ns 10.1ns 0 0 0 1.76 KB
master EnrichedLog netcoreapp3.1 3.44μs 4.38ns 17ns 0 0 0 1.76 KB
master EnrichedLog net472 4.05μs 4.83ns 18.7ns 0.265 0 0 1.69 KB
#7066 EnrichedLog net6.0 2.56μs 12.4ns 54.1ns 0 0 0 1.7 KB
#7066 EnrichedLog netcoreapp3.1 3.5μs 18.4ns 88.4ns 0 0 0 1.71 KB
#7066 EnrichedLog net472 3.97μs 4.62ns 17.9ns 0.258 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7066

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑net6.0 4.37 KB 4.31 KB -56 B -1.28%
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑netcoreapp3.1 4.37 KB 4.31 KB -56 B -1.28%
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑net472 4.57 KB 4.51 KB -60 B -1.31%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 123μs 145ns 563ns 0 0 0 4.37 KB
master EnrichedLog netcoreapp3.1 126μs 330ns 1.24μs 0 0 0 4.37 KB
master EnrichedLog net472 167μs 161ns 603ns 0 0 0 4.57 KB
#7066 EnrichedLog net6.0 121μs 74.3ns 288ns 0 0 0 4.31 KB
#7066 EnrichedLog netcoreapp3.1 128μs 466ns 1.74μs 0 0 0 4.31 KB
#7066 EnrichedLog net472 166μs 81.4ns 315ns 0 0 0 4.51 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7066

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑net6.0 2.32 KB 2.26 KB -56 B -2.41%
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑netcoreapp3.1 2.32 KB 2.26 KB -56 B -2.41%
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑net472 2.14 KB 2.08 KB -56 B -2.62%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.94μs 19.3ns 74.6ns 0 0 0 2.32 KB
master EnrichedLog netcoreapp3.1 6.77μs 22.2ns 79.9ns 0 0 0 2.32 KB
master EnrichedLog net472 7.45μs 8.04ns 31.1ns 0.335 0 0 2.14 KB
#7066 EnrichedLog net6.0 4.92μs 15.1ns 56.5ns 0 0 0 2.26 KB
#7066 EnrichedLog netcoreapp3.1 6.99μs 23.8ns 92.1ns 0 0 0 2.26 KB
#7066 EnrichedLog net472 7.58μs 10.5ns 40.5ns 0.301 0 0 2.08 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7066

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.RedisBenchmark.SendReceive‑net472 1.21 KB 1.2 KB -8 B -0.66%
Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0 1.21 KB 1.2 KB -8 B -0.66%
Benchmarks.Trace.RedisBenchmark.SendReceive‑netcoreapp3.1 1.21 KB 1.2 KB -8 B -0.66%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2.04μs 10.5ns 49.4ns 0 0 0 1.21 KB
master SendReceive netcoreapp3.1 2.53μs 11.8ns 47.4ns 0 0 0 1.21 KB
master SendReceive net472 3.28μs 2.71ns 10.5ns 0.178 0 0 1.21 KB
#7066 SendReceive net6.0 2.05μs 9.5ns 35.6ns 0 0 0 1.2 KB
#7066 SendReceive netcoreapp3.1 2.59μs 10.3ns 39.7ns 0 0 0 1.2 KB
#7066 SendReceive net472 3.22μs 1.92ns 7.44ns 0.176 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7066

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net472 2.08 KB 2.03 KB -56 B -2.69%
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑netcoreapp3.1 1.69 KB 1.63 KB -56 B -3.32%
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net6.0 1.64 KB 1.58 KB -56 B -3.41%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.18μs 0.92ns 3.44ns 0 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 5.64μs 23ns 89.3ns 0 0 0 1.69 KB
master EnrichedLog net472 6.67μs 7.28ns 27.3ns 0.298 0 0 2.08 KB
#7066 EnrichedLog net6.0 4.2μs 1.16ns 4.5ns 0 0 0 1.58 KB
#7066 EnrichedLog netcoreapp3.1 5.58μs 17.1ns 66.1ns 0 0 0 1.63 KB
#7066 EnrichedLog net472 6.73μs 10ns 38.9ns 0.301 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7066

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 704 B 696 B -8 B -1.14%
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 704 B 696 B -8 B -1.14%
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472 666 B 658 B -8 B -1.20%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 586 B 578 B -8 B -1.37%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 584 B 576 B -8 B -1.37%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 584 B 576 B -8 B -1.37%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 751ns 3.97ns 22.4ns 0 0 0 584 B
master StartFinishSpan netcoreapp3.1 953ns 4.42ns 17.7ns 0 0 0 584 B
master StartFinishSpan net472 914ns 0.809ns 3.13ns 0.0912 0 0 586 B
master StartFinishScope net6.0 918ns 0.479ns 1.73ns 0 0 0 704 B
master StartFinishScope netcoreapp3.1 1.15μs 6.24ns 34.2ns 0 0 0 704 B
master StartFinishScope net472 1.09μs 0.174ns 0.652ns 0.104 0 0 666 B
#7066 StartFinishSpan net6.0 749ns 0.332ns 1.29ns 0 0 0 576 B
#7066 StartFinishSpan netcoreapp3.1 955ns 4.92ns 23.6ns 0 0 0 576 B
#7066 StartFinishSpan net472 966ns 0.23ns 0.892ns 0.0907 0 0 578 B
#7066 StartFinishScope net6.0 907ns 0.202ns 0.781ns 0 0 0 696 B
#7066 StartFinishScope netcoreapp3.1 1.16μs 6.35ns 35.9ns 0 0 0 696 B
#7066 StartFinishScope net472 1.11μs 0.183ns 0.686ns 0.0996 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7066

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 704 B 696 B -8 B -1.14%
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 704 B 696 B -8 B -1.14%
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net472 666 B 658 B -8 B -1.20%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.02μs 5.36ns 26.8ns 0 0 0 704 B
master RunOnMethodBegin netcoreapp3.1 1.38μs 2.28ns 8.82ns 0 0 0 704 B
master RunOnMethodBegin net472 1.36μs 0.141ns 0.544ns 0.102 0 0 666 B
#7066 RunOnMethodBegin net6.0 1.03μs 4.97ns 20.5ns 0 0 0 696 B
#7066 RunOnMethodBegin netcoreapp3.1 1.41μs 7.15ns 33.5ns 0 0 0 696 B
#7066 RunOnMethodBegin net472 1.41μs 0.237ns 0.916ns 0.0985 0 0 658 B

@gleocadie gleocadie force-pushed the gleocadie/use-ringbuffer-with-timer_create branch 7 times, most recently from fb2e9a0 to 4ab3867 Compare June 17, 2025 15:08
@gleocadie gleocadie force-pushed the gleocadie/use-ringbuffer-with-timer_create branch from 4ab3867 to 26a5d67 Compare June 24, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area:profiler Issues related to the continous-profiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gleocadie @andrewlock