Skip to content

Remove flaky datapipeline tests #7124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025

Conversation

andrewlock
Copy link
Member

Summary of changes

Remove datapipeline tests which are causing a lot of flakiness, particularly with named pipes

Reason for change

These tests are failing a lot due to duplicate spans in the payload. It needs investigating, and this PR should be reverted once the issue has been fixed.

Implementation details

Delete the data pipeline tests. It's not easy to explicitly skip them, because of their usage in theory tests rather than facts

Test coverage

Less now. This must be reverted before we enable datapipeline usage

@andrewlock andrewlock added the area:tests unit tests, integration tests label Jun 20, 2025
@andrewlock andrewlock requested a review from a team as a code owner June 20, 2025 11:38
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jun 20, 2025

Datadog Report

All test runs bec266f 🔗

2 Total Test Services: 0 Failed, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Test Service View
dd-trace-dotnet 0 0 0 250315 2358 15h 20m 32.9s Link
exploration_tests 0 0 0 22085 3 2m 22.57s Link

@andrewlock andrewlock force-pushed the andrew/ci/skip-more-datapipeline-tests branch from 8921c0e to bec266f Compare June 20, 2025 12:15
@pr-commenter
Copy link

pr-commenter bot commented Jun 20, 2025

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7124 compared to master:

  • 1 benchmarks are slower, with geometric mean 1.325
  • 40 benchmarks have fewer allocations
  • 7 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7124

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1 5.75 KB 5.69 KB -68 B -1.18%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net6.0 5.58 KB 5.51 KB -72 B -1.29%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 11.2μs 59.7ns 322ns 0 0 0 5.58 KB
master StartStopWithChild netcoreapp3.1 14.1μs 67.5ns 286ns 0 0 0 5.75 KB
master StartStopWithChild net472 22.1μs 119ns 651ns 1.03 0.411 0.103 6.09 KB
#7124 StartStopWithChild net6.0 11.4μs 37.8ns 146ns 0 0 0 5.51 KB
#7124 StartStopWithChild netcoreapp3.1 13.9μs 73.1ns 366ns 0 0 0 5.69 KB
#7124 StartStopWithChild net472 22μs 121ns 684ns 0.877 0.219 0 6.1 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7124

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 3.33 KB 3.31 KB -23 B -0.69%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 927μs 26.6ns 103ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.04ms 404ns 1.56μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.25ms 357ns 1.38μs 0 0 0 3.33 KB
#7124 WriteAndFlushEnrichedTraces net6.0 940μs 84ns 314ns 0 0 0 2.7 KB
#7124 WriteAndFlushEnrichedTraces netcoreapp3.1 1.02ms 43.2ns 162ns 0 0 0 2.7 KB
#7124 WriteAndFlushEnrichedTraces net472 1.22ms 37.3ns 140ns 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7124

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody‑net472 236.35 KB 239.64 KB 3.28 KB 1.39%
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody‑net472 239.87 KB 243.15 KB 3.28 KB 1.37%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 331μs 1.76μs 8.42μs 0 0 0 197.06 KB
master AllCycleSimpleBody netcoreapp3.1 510μs 1.45μs 5.61μs 0 0 0 204.77 KB
master AllCycleSimpleBody net472 436μs 119ns 460ns 36.6 2.16 0 236.35 KB
master AllCycleMoreComplexBody net6.0 338μs 1.76μs 8.8μs 0 0 0 200.56 KB
master AllCycleMoreComplexBody netcoreapp3.1 495μs 987ns 3.56μs 0 0 0 208.18 KB
master AllCycleMoreComplexBody net472 446μs 106ns 412ns 36.6 2.16 0 239.87 KB
master ObjectExtractorSimpleBody net6.0 311ns 1.77ns 12.3ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 409ns 1.93ns 8.2ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 303ns 0.175ns 0.676ns 0.0442 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.52μs 29.5ns 110ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.76μs 36.2ns 140ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.66μs 0.89ns 3.33ns 0.599 0 0 3.8 KB
#7124 AllCycleSimpleBody net6.0 331μs 1.66μs 7.04μs 0 0 0 197.59 KB
#7124 AllCycleSimpleBody netcoreapp3.1 493μs 1.33μs 5.13μs 0 0 0 205.35 KB
#7124 AllCycleSimpleBody net472 442μs 101ns 390ns 36.6 2.16 0 239.64 KB
#7124 AllCycleMoreComplexBody net6.0 345μs 285ns 1.11μs 0 0 0 201.1 KB
#7124 AllCycleMoreComplexBody netcoreapp3.1 511μs 1.87μs 7.24μs 0 0 0 208.77 KB
#7124 AllCycleMoreComplexBody net472 455μs 357ns 1.38μs 37.9 2.23 0 243.15 KB
#7124 ObjectExtractorSimpleBody net6.0 316ns 1.74ns 10.6ns 0 0 0 280 B
#7124 ObjectExtractorSimpleBody netcoreapp3.1 404ns 0.514ns 1.99ns 0 0 0 272 B
#7124 ObjectExtractorSimpleBody net472 304ns 0.0557ns 0.216ns 0.0443 0 0 281 B
#7124 ObjectExtractorMoreComplexBody net6.0 6.29μs 31.4ns 137ns 0 0 0 3.78 KB
#7124 ObjectExtractorMoreComplexBody netcoreapp3.1 7.72μs 37ns 153ns 0 0 0 3.69 KB
#7124 ObjectExtractorMoreComplexBody net472 6.82μs 4.05ns 15.7ns 0.579 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 73.3μs 263ns 984ns 0 0 0 32.41 KB
master EncodeArgs netcoreapp3.1 95.7μs 36.2ns 130ns 0 0 0 32.4 KB
master EncodeArgs net472 107μs 17.6ns 65.8ns 4.82 0 0 32.51 KB
master EncodeLegacyArgs net6.0 143μs 122ns 472ns 0 0 0 2.16 KB
master EncodeLegacyArgs netcoreapp3.1 197μs 42.5ns 147ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 261μs 66.8ns 250ns 0 0 0 2.16 KB
#7124 EncodeArgs net6.0 73.2μs 240ns 899ns 0 0 0 32.4 KB
#7124 EncodeArgs netcoreapp3.1 95.6μs 283ns 1.1μs 0 0 0 32.4 KB
#7124 EncodeArgs net472 105μs 25.2ns 97.7ns 4.74 0 0 32.51 KB
#7124 EncodeLegacyArgs net6.0 145μs 146ns 564ns 0 0 0 2.15 KB
#7124 EncodeLegacyArgs netcoreapp3.1 202μs 341ns 1.32μs 0 0 0 2.14 KB
#7124 EncodeLegacyArgs net472 264μs 299ns 1.16μs 0 0 0 2.16 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 271μs 133ns 499ns 0 0 0 4.55 KB
master RunWafRealisticBenchmark netcoreapp3.1 294μs 264ns 989ns 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 307μs 38.1ns 147ns 0 0 0 4.66 KB
master RunWafRealisticBenchmarkWithAttack net6.0 181μs 80.1ns 300ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 198μs 104ns 404ns 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 207μs 45.3ns 169ns 0 0 0 2.28 KB
#7124 RunWafRealisticBenchmark net6.0 272μs 55ns 206ns 0 0 0 4.55 KB
#7124 RunWafRealisticBenchmark netcoreapp3.1 293μs 130ns 469ns 0 0 0 4.48 KB
#7124 RunWafRealisticBenchmark net472 308μs 34.5ns 129ns 0 0 0 4.66 KB
#7124 RunWafRealisticBenchmarkWithAttack net6.0 184μs 55.8ns 209ns 0 0 0 2.24 KB
#7124 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 196μs 222ns 831ns 0 0 0 2.22 KB
#7124 RunWafRealisticBenchmarkWithAttack net472 208μs 21.8ns 84.4ns 0 0 0 2.29 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.1μs 29ns 104ns 0 0 0 14.53 KB
master SendRequest netcoreapp3.1 69.9μs 118ns 440ns 0 0 0 17.42 KB
master SendRequest net472 0.0171ns 0.00147ns 0.00551ns 0 0 0 0 b
#7124 SendRequest net6.0 60.9μs 38.7ns 150ns 0 0 0 14.52 KB
#7124 SendRequest netcoreapp3.1 70.9μs 92.6ns 334ns 0 0 0 17.42 KB
#7124 SendRequest net472 0.0235ns 0.00125ns 0.00485ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7124

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 41.89 KB 42.71 KB 827 B 1.97%
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 55.75 KB 56.14 KB 391 B 0.70%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 645μs 512ns 1.98μs 0 0 0 41.73 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 631μs 1.67μs 6.67μs 0 0 0 41.89 KB
master WriteAndFlushEnrichedTraces net472 923μs 1.93μs 7.2μs 4.46 0 0 55.75 KB
#7124 WriteAndFlushEnrichedTraces net6.0 673μs 794ns 2.86μs 0 0 0 41.78 KB
#7124 WriteAndFlushEnrichedTraces netcoreapp3.1 691μs 5.25μs 51.2μs 0 0 0 42.71 KB
#7124 WriteAndFlushEnrichedTraces net472 883μs 2.43μs 9.09μs 4.46 0 0 56.14 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7124

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0 1.03 KB 1.02 KB -8 B -0.78%
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑netcoreapp3.1 1.02 KB 1.02 KB -8 B -0.78%
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net472 995 B 987 B -8 B -0.80%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.99μs 10.2ns 46.8ns 0 0 0 1.03 KB
master ExecuteNonQuery netcoreapp3.1 2.53μs 3.43ns 13.3ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.7μs 2.41ns 9.34ns 0.147 0.0134 0 995 B
#7124 ExecuteNonQuery net6.0 1.97μs 8.86ns 30.7ns 0 0 0 1.02 KB
#7124 ExecuteNonQuery netcoreapp3.1 2.56μs 7.36ns 28.5ns 0 0 0 1.02 KB
#7124 ExecuteNonQuery net472 2.95μs 5.93ns 23ns 0.148 0.0148 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7124

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net472 1.11 KB 1.1 KB -8 B -0.72%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑netcoreapp3.1 1.09 KB 1.08 KB -8 B -0.74%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net472 1.05 KB 1.04 KB -8 B -0.76%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0 1.04 KB 1.03 KB -8 B -0.77%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑netcoreapp3.1 1.04 KB 1.03 KB -8 B -0.77%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0 1.02 KB 1.01 KB -8 B -0.79%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.83μs 5.85ns 22.7ns 0 0 0 1.04 KB
master CallElasticsearch netcoreapp3.1 2.3μs 11.8ns 56.6ns 0 0 0 1.04 KB
master CallElasticsearch net472 3.55μs 3.05ns 11.8ns 0.159 0 0 1.05 KB
master CallElasticsearchAsync net6.0 1.81μs 3.89ns 14.5ns 0 0 0 1.02 KB
master CallElasticsearchAsync netcoreapp3.1 2.35μs 7.26ns 28.1ns 0 0 0 1.09 KB
master CallElasticsearchAsync net472 3.84μs 3.19ns 12.4ns 0.169 0 0 1.11 KB
#7124 CallElasticsearch net6.0 1.78μs 6.36ns 23.8ns 0 0 0 1.03 KB
#7124 CallElasticsearch netcoreapp3.1 2.27μs 9.25ns 35.8ns 0 0 0 1.03 KB
#7124 CallElasticsearch net472 3.73μs 4.45ns 17.2ns 0.166 0 0 1.04 KB
#7124 CallElasticsearchAsync net6.0 1.8μs 3.78ns 14.6ns 0 0 0 1.01 KB
#7124 CallElasticsearchAsync netcoreapp3.1 2.47μs 10.1ns 37.7ns 0 0 0 1.08 KB
#7124 CallElasticsearchAsync net472 3.8μs 3.93ns 14.2ns 0.171 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7124

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0 960 B 952 B -8 B -0.83%
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑netcoreapp3.1 960 B 952 B -8 B -0.83%
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net472 923 B 915 B -8 B -0.87%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.78μs 9.27ns 43.5ns 0 0 0 960 B
master ExecuteAsync netcoreapp3.1 2.29μs 7.45ns 25.8ns 0 0 0 960 B
master ExecuteAsync net472 2.58μs 1.78ns 6.88ns 0.143 0 0 923 B
#7124 ExecuteAsync net6.0 2μs 7.05ns 27.3ns 0 0 0 952 B
#7124 ExecuteAsync netcoreapp3.1 2.28μs 2.48ns 8.58ns 0 0 0 952 B
#7124 ExecuteAsync net472 2.55μs 2.24ns 8.39ns 0.138 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 7.1μs 10.4ns 39ns 0 0 0 2.37 KB
master SendAsync netcoreapp3.1 8.69μs 14.1ns 54.6ns 0 0 0 2.9 KB
master SendAsync net472 12.5μs 10.3ns 38.5ns 0.498 0 0 3.19 KB
#7124 SendAsync net6.0 6.92μs 9.92ns 37.1ns 0 0 0 2.36 KB
#7124 SendAsync netcoreapp3.1 8.31μs 10.7ns 41.5ns 0 0 0 2.9 KB
#7124 SendAsync net472 12.3μs 6.17ns 23.9ns 0.49 0 0 3.18 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #7124

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 1.325 413,700.00 548,350.00

More allocations ⚠️ in #7124

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 259.96 KB 276.67 KB 16.71 KB 6.43%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 43.83 KB 44.48 KB 648 B 1.48%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 274.93 KB 276.33 KB 1.4 KB 0.51%

Fewer allocations 🎉 in #7124

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 286.72 KB 278.53 KB -8.19 KB -2.86%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 44.6μs 212ns 1.6μs 0 0 0 43.83 KB
master StringConcatBenchmark netcoreapp3.1 47.2μs 224ns 838ns 0 0 0 42.64 KB
master StringConcatBenchmark net472 56.8μs 259ns 968ns 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 458μs 1.08μs 3.89μs 0 0 0 259.96 KB
master StringConcatAspectBenchmark netcoreapp3.1 447μs 6.44μs 63.7μs 0 0 0 274.93 KB
master StringConcatAspectBenchmark net472 410μs 2.07μs 9.27μs 0 0 0 286.72 KB
#7124 StringConcatBenchmark net6.0 41.8μs 205ns 819ns 0 0 0 44.48 KB
#7124 StringConcatBenchmark netcoreapp3.1 48.8μs 421ns 4.02μs 0 0 0 42.81 KB
#7124 StringConcatBenchmark net472 57.3μs 162ns 585ns 0 0 0 57.34 KB
#7124 StringConcatAspectBenchmark net6.0 499μs 2.15μs 7.75μs 0 0 0 276.67 KB
#7124 StringConcatAspectBenchmark netcoreapp3.1 550μs 1.62μs 5.82μs 0 0 0 276.33 KB
#7124 StringConcatAspectBenchmark net472 408μs 2.03μs 9.07μs 0 0 0 278.53 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7124

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0 1.76 KB 1.7 KB -56 B -3.18%
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑netcoreapp3.1 1.76 KB 1.7 KB -56 B -3.18%
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net472 1.69 KB 1.64 KB -56 B -3.31%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.63μs 2.6ns 10.1ns 0 0 0 1.76 KB
master EnrichedLog netcoreapp3.1 3.44μs 4.38ns 17ns 0 0 0 1.76 KB
master EnrichedLog net472 4.05μs 4.83ns 18.7ns 0.265 0 0 1.69 KB
#7124 EnrichedLog net6.0 2.54μs 12ns 48.1ns 0 0 0 1.7 KB
#7124 EnrichedLog netcoreapp3.1 3.57μs 17.4ns 71.6ns 0 0 0 1.7 KB
#7124 EnrichedLog net472 3.9μs 2.16ns 8.37ns 0.253 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7124

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑net6.0 4.37 KB 4.31 KB -56 B -1.28%
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑net472 4.57 KB 4.51 KB -60 B -1.31%
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑netcoreapp3.1 4.37 KB 4.31 KB -58 B -1.33%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 123μs 145ns 563ns 0 0 0 4.37 KB
master EnrichedLog netcoreapp3.1 126μs 330ns 1.24μs 0 0 0 4.37 KB
master EnrichedLog net472 167μs 161ns 603ns 0 0 0 4.57 KB
#7124 EnrichedLog net6.0 122μs 67.2ns 260ns 0 0 0 4.31 KB
#7124 EnrichedLog netcoreapp3.1 125μs 78.4ns 283ns 0 0 0 4.31 KB
#7124 EnrichedLog net472 166μs 106ns 395ns 0 0 0 4.51 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7124

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑net6.0 2.32 KB 2.26 KB -56 B -2.41%
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑netcoreapp3.1 2.32 KB 2.26 KB -56 B -2.41%
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑net472 2.14 KB 2.08 KB -56 B -2.62%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.94μs 19.3ns 74.6ns 0 0 0 2.32 KB
master EnrichedLog netcoreapp3.1 6.77μs 22.2ns 79.9ns 0 0 0 2.32 KB
master EnrichedLog net472 7.45μs 8.04ns 31.1ns 0.335 0 0 2.14 KB
#7124 EnrichedLog net6.0 4.94μs 6.78ns 26.3ns 0 0 0 2.26 KB
#7124 EnrichedLog netcoreapp3.1 6.78μs 22.7ns 87.9ns 0 0 0 2.26 KB
#7124 EnrichedLog net472 7.5μs 6.74ns 26.1ns 0.298 0 0 2.08 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7124

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.RedisBenchmark.SendReceive‑net472 1.21 KB 1.2 KB -8 B -0.66%
Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0 1.21 KB 1.2 KB -8 B -0.66%
Benchmarks.Trace.RedisBenchmark.SendReceive‑netcoreapp3.1 1.21 KB 1.2 KB -8 B -0.66%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2.04μs 10.5ns 49.4ns 0 0 0 1.21 KB
master SendReceive netcoreapp3.1 2.53μs 11.8ns 47.4ns 0 0 0 1.21 KB
master SendReceive net472 3.28μs 2.71ns 10.5ns 0.178 0 0 1.21 KB
#7124 SendReceive net6.0 1.99μs 10.2ns 45.7ns 0 0 0 1.2 KB
#7124 SendReceive netcoreapp3.1 2.59μs 10.1ns 39.1ns 0 0 0 1.2 KB
#7124 SendReceive net472 3.19μs 11ns 42.4ns 0.176 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7124

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net472 2.08 KB 2.03 KB -56 B -2.69%
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑netcoreapp3.1 1.69 KB 1.63 KB -56 B -3.32%
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net6.0 1.64 KB 1.58 KB -56 B -3.41%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.18μs 0.92ns 3.44ns 0 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 5.64μs 23ns 89.3ns 0 0 0 1.69 KB
master EnrichedLog net472 6.67μs 7.28ns 27.3ns 0.298 0 0 2.08 KB
#7124 EnrichedLog net6.0 4.24μs 7.09ns 27.4ns 0 0 0 1.58 KB
#7124 EnrichedLog netcoreapp3.1 5.59μs 10ns 38.9ns 0 0 0 1.63 KB
#7124 EnrichedLog net472 6.66μs 6.02ns 23.3ns 0.299 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7124

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 704 B 696 B -8 B -1.14%
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 704 B 696 B -8 B -1.14%
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472 666 B 658 B -8 B -1.20%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 586 B 578 B -8 B -1.37%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 584 B 576 B -8 B -1.37%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 584 B 576 B -8 B -1.37%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 751ns 3.97ns 22.4ns 0 0 0 584 B
master StartFinishSpan netcoreapp3.1 953ns 4.42ns 17.7ns 0 0 0 584 B
master StartFinishSpan net472 914ns 0.809ns 3.13ns 0.0912 0 0 586 B
master StartFinishScope net6.0 918ns 0.479ns 1.73ns 0 0 0 704 B
master StartFinishScope netcoreapp3.1 1.15μs 6.24ns 34.2ns 0 0 0 704 B
master StartFinishScope net472 1.09μs 0.174ns 0.652ns 0.104 0 0 666 B
#7124 StartFinishSpan net6.0 743ns 3.98ns 19.9ns 0 0 0 576 B
#7124 StartFinishSpan netcoreapp3.1 951ns 4.52ns 17.5ns 0 0 0 576 B
#7124 StartFinishSpan net472 918ns 0.0746ns 0.279ns 0.0878 0 0 578 B
#7124 StartFinishScope net6.0 905ns 4.32ns 16.7ns 0 0 0 696 B
#7124 StartFinishScope netcoreapp3.1 1.18μs 6.35ns 32.4ns 0 0 0 696 B
#7124 StartFinishScope net472 1.09μs 0.688ns 2.57ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7124

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 704 B 696 B -8 B -1.14%
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 704 B 696 B -8 B -1.14%
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net472 666 B 658 B -8 B -1.20%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.02μs 5.36ns 26.8ns 0 0 0 704 B
master RunOnMethodBegin netcoreapp3.1 1.38μs 2.28ns 8.82ns 0 0 0 704 B
master RunOnMethodBegin net472 1.36μs 0.141ns 0.544ns 0.102 0 0 666 B
#7124 RunOnMethodBegin net6.0 1.07μs 3.15ns 11.8ns 0 0 0 696 B
#7124 RunOnMethodBegin netcoreapp3.1 1.43μs 7.43ns 34ns 0 0 0 696 B
#7124 RunOnMethodBegin net472 1.42μs 1.22ns 4.73ns 0.0993 0 0 658 B

@andrewlock andrewlock merged commit 3778f9e into master Jun 23, 2025
131 checks passed
@andrewlock andrewlock deleted the andrew/ci/skip-more-datapipeline-tests branch June 23, 2025 08:59
@github-actions github-actions bot added this to the vNext-v3 milestone Jun 23, 2025
chojomok pushed a commit that referenced this pull request Jul 15, 2025
## Summary of changes

Remove datapipeline tests which are causing a lot of flakiness,
particularly with named pipes

## Reason for change

These tests are failing a _lot_ due to duplicate spans in the payload.
It needs investigating, and this PR should be reverted once the issue
has been fixed.

## Implementation details

Delete the data pipeline tests. It's not easy to explicitly skip them,
because of their usage in theory tests rather than facts

## Test coverage

Less now. This must be reverted before we enable datapipeline usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:tests unit tests, integration tests type:flake-fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants