-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Feature/upgrade newtonsoft.json to its latest package #2489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Feature/upgrade newtonsoft.json to its latest package #2489
Conversation
Upgrade Newtonsoft.Json to v13.0.3 across all projects to address vulnerabilities and standardize versions This PR updates Newtonsoft.Json to version 13.0.3 across all projects for the following reasons: Fixing Vulnerabilities: Version Consistency: Hangfire.Core and related tests: 5.0.1 Future-proofing: |
Be nice to see the build failures fixed so that this can be merged in and released... |
Why hasn't any one looked at the failed tests? Newtonsoft.Json 11.0.1 has a known high severity vulnerability, and should be updated asap |
Whats the ETA of this ? We are waiting for this PR since newtonsoft is exploitable |
@odinserj: It seems that you're actively submitting changes to this repo and having them pass checks and build properly in AppVeyor. If you could look at the AppVeyor failure in this PR to help move it along, that would be appreciated. |
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" /> Please see #2468 (comment) for details. |
I wish you hadn't closed this PR, unless 1.9.0 is on the verge of release. This warning has been around for a while, would be nice to see it addressed at the root rather than push work onto every Hangfire client by suggesting they take on dependencies they don't otherwise need, which also means maintaining those dependencies as well over time.
Can you share a non-committing ETA for Hangfire 1.9.0? Even if it's just when you hope to release it? |
I'm planning to release it before the release of .NET 10 that will re-enable transient dependency checks again. |
No description provided.