Skip to content

Test PkgEval effect of deleting slow path debuginfo lookup on 1.12 #58676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

KristofferC
Copy link
Member

There are quite a few packages that time out on 1.12. I want to see if it has to do with this slow debuginfo lookup that happens for deprecation warnings.

This slow-path is hard to justify, both because it is slow (it scans
1-by-1 through every symbol in a library) and also because its results
are very frequently thrown out and replaced with fast-lookup from the
DWARF info right after.

The latter issue could be resolved with some re-factoring, but the
former is bad enough that I think we should just delete this and take
the policy that stack frame lookup requires unwind or debug info in your
libraries.

(cherry picked from commit f1b424a)
@KristofferC KristofferC added the DO NOT MERGE Do not merge this PR! label Jun 9, 2025
@KristofferC
Copy link
Member Author

@nanosoldier runtests(["SymbolicIndexingInterface", "OSQP", "SoleBase", "FastCholesky", "EnergySamplers", "JUDI", "GMT", "NeutralLandscapes", "PRASCapacityCredits", "DataToolkitCommon", "WaveOpticsPropagation", "AdmittanceModels", "YAAD", "Quante", "ParaReal", "LaserTypes", "GEOTRACES", "Mango", "Sensemakr", "XCALibre", "ExplainableAI", "SimulationLogs", "GeometricalOptics", "DynamicMovementPrimitives", "DistributedStwdLDA", "DiffusionGarnet", "MultiStateSystems", "vSmartMOM", "WGPUgfx", "MAGEMinApp", "MRINavigator", "CropRootBox", "FSimPlots"], vs = ":backports-release-1.12")

@nanosoldier
Copy link
Collaborator

The package evaluation job you requested has completed - no new issues were detected.
The full report is available.

Report summary

❗ Packages that crashed

1 packages crashed only on the current version.

  • The process was aborted: 1 packages

✖ Packages that failed

17 packages failed on the previous version too.

✔ Packages that passed tests

6 packages passed tests only on the current version.

  • Other: 6 packages

7 packages passed tests on the previous version too.

➖ Packages that were skipped altogether

1 packages were skipped only on the current version.

  • Package could not be installed: 1 packages

1 packages were skipped on the previous version too.

@KristofferC
Copy link
Member Author

Both OrdinaryDiffEq and GPUCompiler seems to be broken at thet time when running this. OrdinaryDiffEq should have been fixed by JuliaObjects/ConstructionBase.jl#102 and GPUCompiler needs a tweak.

@KristofferC
Copy link
Member Author

@nanosoldier runtests(["SymbolicIndexingInterface", "OSQP", "SoleBase", "FastCholesky", "EnergySamplers", "JUDI", "GMT", "NeutralLandscapes", "PRASCapacityCredits", "DataToolkitCommon", "WaveOpticsPropagation", "AdmittanceModels", "YAAD", "Quante", "ParaReal", "LaserTypes", "GEOTRACES", "Mango", "Sensemakr", "XCALibre", "ExplainableAI", "SimulationLogs", "GeometricalOptics", "DynamicMovementPrimitives", "DistributedStwdLDA", "DiffusionGarnet", "MultiStateSystems", "vSmartMOM", "WGPUgfx", "MAGEMinApp", "MRINavigator", "CropRootBox", "FSimPlots"], vs = ":release-1.12")

@nanosoldier
Copy link
Collaborator

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

Report summary

✖ Packages that failed

5 packages failed only on the current version.

  • Package fails to precompile: 5 packages

13 packages failed on the previous version too.

✔ Packages that passed tests

7 packages passed tests only on the current version.

  • Other: 7 packages

7 packages passed tests on the previous version too.

➖ Packages that were skipped altogether

1 packages were skipped on the previous version too.

@KristofferC KristofferC closed this Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Do not merge this PR!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants