Improve score by supporting extra_phrase for extra words in rules
#4432
Conversation
alok1304
force-pushed
the
improve-score-extra-words
branch
3 times, most recently
from
6b7da16 to
8fb9f47
Compare
alok1304
moved this to In Progress
in GSoC 2025: Have variable license sections in license rules @alok1304
alok1304
force-pushed
the
improve-score-extra-words
branch
8 times, most recently
from
ac99199 to
9b50bff
Compare
There was a problem hiding this comment.
Thanks @alok1304! Looking much better
See comments for your consideration. I've updated your PR description to mention that this is a follow up PR, since there is important context and reviews in the previous PR, we need to preserve this as required.
| """ | ||
| Return True if any of the matches in ``license_matches`` List of LicenseMatch | ||
| has extra words are in the correct place. | ||
| """ |
There was a problem hiding this comment.
We need to check both a bit explicitly:
- For all the matches which have extra words, they are in correct location
- For all the matches which does not have extra words, they are correct detections
There was a problem hiding this comment.
And add a test accordingly
There was a problem hiding this comment.
And add a test accordingly
where I should add a test and like how I implement for all license_matches
alok1304
force-pushed
the
improve-score-extra-words
branch
from
b9c7c16 to
a50b3db
Compare
|
I addet test for Next things we want: Some test cases are failing; I will solve them in the next commit. |
…_log` Add test for is correct position of `extra-words` according to `extra-phrases` that is present in rules. if we find `extra-words` are in the right place then we set score to `100`. And also show in `detection_log` why we increasing the score to keep track of this. Signed-off-by: Alok Kumar <alokkumarjipura9973@gmail.com>
Add new phrases like `extra_phrase` this is special for extra-words. This phrase is represented in the format [[n]], where n indicates the maximum number of extra-words allowed at that position in the rule. If extra-words appear at the correct position and their count does not exceed the allowed limit `n`, then the score is increased to `100`. Signed-off-by: Alok Kumar <alokkumarjipura9973@gmail.com>
Signed-off-by: Alok Kumar <alokkumarjipura9973@gmail.com>
due to `extra_phrase` in rules, this shows that rules containing `extra-words` Signed-off-by: Alok Kumar <alokkumarjipura9973@gmail.com>
Signed-off-by: Alok Kumar <alokkumarjipura9973@gmail.com>
Signed-off-by: Alok Kumar <alokkumarjipura9973@gmail.com>
add a new `extra-phrase` for a rule i.e bsd-new Signed-off-by: Alok Kumar <alokkumarjipura9973@gmail.com>
Signed-off-by: Alok Kumar <alokkumarjipura9973@gmail.com>
alok1304
force-pushed
the
improve-score-extra-words
branch
from
8a25b51 to
43c6bdb
Compare
Follow up of:
extra_phrasefor extra words in rules #4424Add new phrases like
extra_phrasethis is special forextra-words. This phrase is represented in the format[[n]], where n indicates the maximum number ofextra-wordsallowed at that position in the rule.If
extra-wordsappear at the correct position and their count does not exceed the allowed limitn, then the score is increased to100.Reference #4420
Tasks
Run tests locally to check for errors.
Signed-off-by: Alok Kumar alokkumarjipura9973@gmail.com