-
Notifications
You must be signed in to change notification settings - Fork 3.8k
GH-46214: [C++] Improve S3 client initialization #46723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @apmorton |
d90e175
to
cbf8592
Compare
cbf8592
to
be5865a
Compare
@github-actions crossbow submit -g python -g cpp |
@github-actions crossbow submit wheelcp313* |
This comment was marked as outdated.
This comment was marked as outdated.
@github-actions crossbow submit -g python -g cpp |
This comment was marked as outdated.
This comment was marked as outdated.
be5865a
to
80bf6ee
Compare
@github-actions crossbow submit -g python -g cpp |
Revision: 80bf6ee Submitted crossbow builds: ursacomputing/crossbow @ actions-e43f4463ab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 6080ca6. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Rationale for this change
The default constructor of the
S3ClientConfiguration
class in the AWS SDK issues spurious EC2 metadata requests, even though we later set up the configuration values ourselves.What changes are included in this PR?
S3ClientConfiguration
constructorS3Options
Benchmarks on my local work machine:
Are these changes tested?
By existing CI tests and configurations.
Are there any user-facing changes?
The default S3 settings are potentially changed. Hopefully this will not trigger any regression in behavior.