Skip to content

GH-46871: [C++][Parquet] Restore implementation of 3 arrow::FileReader::GetRecordBatchReader() functions #46868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025

Conversation

rouault
Copy link
Contributor

@rouault rouault commented Jun 19, 2025

Rationale for this change

Those functions were accidentally removed in f7bc271 whereas only the variants using unique_ptr<> were intended for removal.

What changes are included in this PR?

Restore the implementation of 3 functions whose prototype is still available

Are these changes tested?

Apparently no

Are there any user-facing changes?

No (unbreak a unreleased regression)

Cf #46867 (comment) for discussion

…rdBatchReader() functions

Those functions were accidentally removed in f7bc271
whereas only the variants using unique_ptr<> were intended for removal.
@rouault rouault requested a review from wgtmac as a code owner June 19, 2025 21:41
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@kou
Copy link
Member

kou commented Jun 20, 2025

Could you open a new issue for this?

@AlenkaF
Copy link
Member

AlenkaF commented Jun 20, 2025

Thank you for catching this and making a PR @rouault, much appreciated!
I have opened an issue here: #46871

@AlenkaF AlenkaF changed the title [C++][Parquet] Restore implementation of 3 arrow::FileReader::GetRecordBatchReader() functions GH-46871: [C++][Parquet] Restore implementation of 3 arrow::FileReader::GetRecordBatchReader() functions Jun 20, 2025
Copy link

⚠️ GitHub issue #46871 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Jun 20, 2025
Copy link

⚠️ GitHub issue #46871 has been automatically assigned in GitHub to PR creator.

@AlenkaF AlenkaF merged commit dacec30 into apache:main Jun 23, 2025
36 checks passed
@AlenkaF AlenkaF removed the awaiting committer review Awaiting committer review label Jun 23, 2025
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit dacec30.

There were 119 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants