GH-46895: [CI][Dev] Fix shellcheck errors in the ci/scripts/install_minio.sh

[hiroyuki-sato]

Rationale for this change

This is the sub issue #44748.

• SC2046: Quote this to prevent word splitting.
• SC2086: Double quote to prevent globbing and word splitting.

shellcheck ci/scripts/install_minio.sh

In ci/scripts/install_minio.sh line 37:
if [ -z ${archs[$arch]} ]; then
        ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
if [ -z "${archs[$arch]}" ]; then


In ci/scripts/install_minio.sh line 74:
  mkdir -p $(dirname ${output})
           ^------------------^ SC2046 (warning): Quote this to prevent word splitting.
                     ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
  mkdir -p $(dirname "${output}")


In ci/scripts/install_minio.sh line 76:
    wget -nv --output-document ${output} ${url}
                               ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                         ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    wget -nv --output-document "${output}" "${url}"


In ci/scripts/install_minio.sh line 78:
    curl --fail --location --output ${output} ${url}
                                    ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                              ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    curl --fail --location --output "${output}" "${url}"


In ci/scripts/install_minio.sh line 85:
  download ${prefix}/bin/minio ${url}
           ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                               ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
  download "${prefix}"/bin/minio "${url}"


In ci/scripts/install_minio.sh line 86:
  chmod +x ${prefix}/bin/minio
           ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
  chmod +x "${prefix}"/bin/minio


In ci/scripts/install_minio.sh line 91:
  download ${prefix}/bin/mc ${url}
           ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                            ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
  download "${prefix}"/bin/mc "${url}"


In ci/scripts/install_minio.sh line 92:
  chmod +x ${prefix}/bin/mc
           ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
  chmod +x "${prefix}"/bin/mc

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

What changes are included in this PR?

• Quote variables.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

• GitHub Issue: [CI][Dev] Fix shellcheck errors in the ci/scripts/install_minio.sh #46895

[github-actions]

⚠️ GitHub issue #46895 has been automatically assigned in GitHub to PR creator.

[hiroyuki-sato]

The cpp.yml is using install_minio.sh.
And CI of C++ related jobs passed.

Do we need additional tests?

arrow/.github/workflows/cpp.yml

Line 236 in 19fb7bb

ci/scripts/install_minio.sh latest ${ARROW_HOME}

[kou]

+1

[conbench-apache-arrow]

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit f5e868e.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.