Skip to content

reformat table #2221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

reformat table #2221

wants to merge 1 commit into from

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Apr 2, 2025

No description provided.

@elharo elharo marked this pull request as ready for review April 3, 2025 11:21
@elharo elharo requested a review from michael-o April 3, 2025 11:22
Copy link
Contributor

@gnodet gnodet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1

This code is generated afaik:

maven/apache-maven/pom.xml

Lines 271 to 302 in d80804c

<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>exec-maven-plugin</artifactId>
<version>3.5.0</version>
<executions>
<execution>
<id>render-configuration-page</id>
<goals>
<goal>java</goal>
</goals>
<phase>verify</phase>
<configuration>
<classpathScope>test</classpathScope>
<additionalClasspathElements>
<additionalClasspathElement>${basedir}/src/test/resources</additionalClasspathElement>
</additionalClasspathElements>
<mainClass>org.eclipse.aether.tools.CollectConfiguration</mainClass>
<arguments>
<argument>--mode=maven</argument>
<!--
TODO: templates are loaded from classpath, in "normal" JAR project local template would override docgen one,
but in this case the packaging=pom all I could do is use additionalClasspathElement that APPENDS classpath,
hence template is renamed to maven-configuration.md.vm, to avoid conflict (and picking up resolver template)
-->
<argument>--templates=maven-configuration.md,configuration.properties,configuration.yaml</argument>
<argument>${basedir}/..</argument>
<argument>${basedir}/../src/site/markdown/</argument>
</arguments>
</configuration>
</execution>
</executions>
</plugin>

The templates are actually embedded in the corresponding resolver jar.

@michael-o
Copy link
Member

This file should contain an appropriate header for auto-generation

@michael-o michael-o removed their request for review April 6, 2025 19:23
@gnodet
Copy link
Contributor

gnodet commented Apr 25, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants