-
Notifications
You must be signed in to change notification settings - Fork 68
chore/SRE-583 Deprecate usage of Auth-Email Header #1528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore/SRE-583 Deprecate usage of Auth-Email Header #1528
Conversation
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1528 +/- ##
==========================================
- Coverage 88.59% 88.58% -0.01%
==========================================
Files 810 810
Lines 51276 51270 -6
==========================================
- Hits 45426 45420 -6
Misses 5850 5850 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BitwardenShared/Core/Auth/Services/API/Auth/Requests/IdentityTokenRequest.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔Additionally to what Matt commented, should this be behind a feature flag so we can better control when to disable the code? Not sure when this was deprecated on server, but there may be people using old self-host server versions and they will need the header to perform a good request.
This is a good call out. Server-side deprecation was done here bitwarden/server#5709 We are past the support window according to https://bitwarden.com/help/bitwarden-software-release-support/ |
079cebd
to
d65248f
Compare
Added the server PR to the description. @fedemkr are you ok with the changes? |
d65248f
to
ba968d7
Compare
🎟️ Tracking
https://bitwarden.atlassian.net/browse/SRE-583
📔 Objective
Deprecate usage of Auth-Email Header
Server side changes: bitwarden/server#5709
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes