Skip to content

Conversation

bitwarden-charlie
Copy link
Contributor

@bitwarden-charlie bitwarden-charlie commented Apr 25, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/SRE-583

📔 Objective

Deprecate usage of Auth-Email Header

Server side changes: bitwarden/server#5709

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Apr 25, 2025

Logo
Checkmarx One – Scan Summary & Details531a1738-de50-4150-ad4f-d732983e9a42

Great job! No new security vulnerabilities introduced in this pull request

Copy link

codecov bot commented Apr 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.58%. Comparing base (244feb4) to head (f462b6b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1528      +/-   ##
==========================================
- Coverage   88.59%   88.58%   -0.01%     
==========================================
  Files         810      810              
  Lines       51276    51270       -6     
==========================================
- Hits        45426    45420       -6     
  Misses       5850     5850              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@fedemkr fedemkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔Additionally to what Matt commented, should this be behind a feature flag so we can better control when to disable the code? Not sure when this was deprecated on server, but there may be people using old self-host server versions and they will need the header to perform a good request.

@sneakernuts
Copy link
Member

🤔Additionally to what Matt commented, should this be behind a feature flag so we can better control when to disable the code? Not sure when this was deprecated on server, but there may be people using old self-host server versions and they will need the header to perform a good request.

This is a good call out. Server-side deprecation was done here bitwarden/server#5709

We are past the support window according to https://bitwarden.com/help/bitwarden-software-release-support/

@sneakernuts sneakernuts force-pushed the chore/SRE-583-Deprecate-usage-of-Auth-Email-Header branch 4 times, most recently from 079cebd to d65248f Compare August 18, 2025 18:38
@vvolkgang
Copy link
Member

Added the server PR to the description. @fedemkr are you ok with the changes?

@sneakernuts sneakernuts force-pushed the chore/SRE-583-Deprecate-usage-of-Auth-Email-Header branch from d65248f to ba968d7 Compare August 18, 2025 21:06
@sneakernuts sneakernuts merged commit c1b4334 into main Aug 18, 2025
10 checks passed
@sneakernuts sneakernuts deleted the chore/SRE-583-Deprecate-usage-of-Auth-Email-Header branch August 18, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants