[BRE-769] Use Fastlane to keep github releases in sync with mobile deploy versions #1593
Conversation
michalchecinski
requested review from
a team and
Eeebru
and removed request for
a team
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1593 +/- ##
==========================================
- Coverage 89.40% 85.76% -3.64%
==========================================
Files 798 996 +198
Lines 50600 60485 +9885
==========================================
+ Hits 45240 51877 +6637
- Misses 5360 8608 +3248 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…pre-release details and streamline release process
There was a problem hiding this comment.
Waiting for the changes requested in https://github.com/bitwarden/android/pull/5219/files
…d Manager releases; update Fastfile to set STORE_VERSION in GitHub environment
|
@vvolkgang do we have fastlane enabled for iOS Authenticator? Also, I've extracted the action to gh-actions repo to reuse it both here and in the Android repo: bitwarden/gh-actions#401 |
…nticator and Password Manager into a single workflow file
…ssary environment variable exports
fastlane/Fastfile
Outdated
| @@ -31,4 +31,16 @@ platform :ios do |options| | |||
| } | |||
| ) | |||
| end | |||
|
|
|||
| desc "Get latest published version" | |||
| lane :get_latest_version do | |||
There was a problem hiding this comment.
Not differentiating between Password Manager and Authenticator. We can receive the bundle ID (app_identifier) as an argument here.
fastlane/Fastfile
Outdated
|
|
||
| desc "Get latest published version" | ||
| lane :get_latest_version do | ||
| app_STORE_VERSION_NUMBER( |
There was a problem hiding this comment.
This should probably be lowercase.
| credentials_filename: "appstoreconnect-fastlane.json" | ||
| project_type: ios | ||
| check_release_command: > | ||
| bundle exec fastlane ios get_latest_version_authenticator api_key_path:$CREDENTIALS_PATH |
|
@vvolkgang Should be good to go |
…-in-sync-with-mobile-deploy-versions
|
@vvolkgang Tested the workflow. Seems to be working fine now: https://github.com/bitwarden/ios/actions/runs/16055035313 |
…-in-sync-with-mobile-deploy-versions
michalchecinski
deleted the
BRE-769-Use-Fastlane-to-keep-github-releases-in-sync-with-mobile-deploy-versions
branch
🎟️ Tracking
https://bitwarden.atlassian.net/browse/BRE-769
📔 Objective
Add a workflow to check for new iOS version submitted to the stores. If a new version exists, publish the GitHub release as the latest and non-pre-release.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes