Skip to content

[deps] Update Firebase to 11.14.0 #1670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2025

Conversation

KatherineInCode
Copy link
Contributor

📔 Objective

This updates Firebase to 11.14.0. Manual PR since renovate currently doesn't work on our project*.yml files.

It does appear that with the minor update we also now bring in Google Ads on Device Conversion by way of GoogleAppMeasurement, which is brought in by Firebase.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Jun 16, 2025

Logo
Checkmarx One – Scan Summary & Detailsc1c10720-911c-4af7-9b4d-736efaa4f320

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.73%. Comparing base (99f8278) to head (ed93488).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1670      +/-   ##
==========================================
- Coverage   89.38%   85.73%   -3.65%     
==========================================
  Files         798      996     +198     
  Lines       50419    60293    +9874     
==========================================
+ Hits        45066    51692    +6626     
- Misses       5353     8601    +3248     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KatherineInCode KatherineInCode marked this pull request as ready for review June 17, 2025 14:01
@KatherineInCode KatherineInCode requested review from matt-livefront and a team as code owners June 17, 2025 14:01
@KatherineInCode
Copy link
Contributor Author

@fedemkr Are you good with merging this in? I know you had some concerns about the new library, and wanted to make sure those were sufficiently allayed.

@fedemkr
Copy link
Member

fedemkr commented Jun 25, 2025

Yes, that's fine; thanks for the ping on this! Approved 🚀

@KatherineInCode KatherineInCode merged commit ae0aaee into main Jun 25, 2025
12 checks passed
@KatherineInCode KatherineInCode deleted the katherine/firebase-update-11.14.0 branch June 25, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants