Skip to content

[PM-22884] Remove extra action sheet in logout flow from vault unlock #1680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

matt-livefront
Copy link
Collaborator

@matt-livefront matt-livefront commented Jun 20, 2025

🎟️ Tracking

PM-22884

📔 Objective

In the logout flow from vault unlock, there's an extra action sheet which requires tapping 'Log out' twice which can be removed. The updated flow is:

  • Tap the options button to show a context menu
  • Tap 'Log out' from the context menu
  • The log out confirmation alert is shown

📸 Screenshots

Before After
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-06-19.at.16.36.22.mp4
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-06-20.at.10.38.15.mp4

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@matt-livefront matt-livefront requested a review from a team as a code owner June 20, 2025 15:50
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details00444e09-2648-4678-8b34-6762fb49456b

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.38%. Comparing base (7c629f7) to head (fa98866).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1680      +/-   ##
==========================================
- Coverage   89.38%   89.38%   -0.01%     
==========================================
  Files         798      798              
  Lines       50450    50439      -11     
==========================================
- Hits        45094    45083      -11     
  Misses       5356     5356              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matt-livefront matt-livefront merged commit 7c9af43 into main Jun 24, 2025
10 checks passed
@matt-livefront matt-livefront deleted the matt/PM-22884-vault-unlock-logout branch June 24, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants