Skip to content

Fix permissions for check-run action #5963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mandreko-bitwarden
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/VULN-252

📔 Objective

Further restrict permissions to check-run, to prevent abuse of github tokens

Created this second PR, due to a failed rebase on #5945

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Jun 13, 2025

Logo
Checkmarx One – Scan Summary & Details75171ace-cf97-4aaa-a99c-fa0de111cc11

New Issues (6)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
HIGH Path_Traversal /src/Api/Tools/Controllers/SendsController.cs: 211
detailsMethod PostFile at line 211 of /src/Api/Tools/Controllers/SendsController.cs gets dynamic data from the model element. This element’s value then ...
ID: keY0wh5knH3DnvbREmfJIGGig2k%3D
Attack Vector
HIGH Path_Traversal /src/Api/Tools/Controllers/SendsController.cs: 211
detailsMethod PostFile at line 211 of /src/Api/Tools/Controllers/SendsController.cs gets dynamic data from the model element. This element’s value then ...
ID: 4QIsZ8agHxuL%2BFjdf49NpZJHsvU%3D
Attack Vector
HIGH Path_Traversal /src/Api/Tools/Controllers/SendsController.cs: 211
detailsMethod PostFile at line 211 of /src/Api/Tools/Controllers/SendsController.cs gets dynamic data from the model element. This element’s value then ...
ID: Uwek2GQ3fAsDgtQkgYKs2Vkocog%3D
Attack Vector
HIGH Path_Traversal /src/Api/Tools/Controllers/SendsController.cs: 211
detailsMethod PostFile at line 211 of /src/Api/Tools/Controllers/SendsController.cs gets dynamic data from the model element. This element’s value then ...
ID: OxfkMdVQRO3StOFifYOfb36o2%2Bw%3D
Attack Vector
HIGH Path_Traversal /src/Api/Tools/Controllers/SendsController.cs: 211
detailsMethod PostFile at line 211 of /src/Api/Tools/Controllers/SendsController.cs gets dynamic data from the model element. This element’s value then ...
ID: HvNxhQLOT4P0U2Lbp6HqePXg%2FNQ%3D
Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 133
detailsMethod Put at line 133 of /src/Api/AdminConsole/Public/Controllers/GroupsController.cs gets a parameter from a user request from model. This para...
ID: i9fpgrI7qjupFHki1HVkAhd5x%2Bs%3D
Attack Vector
Fixed Issues (2)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM CSRF /bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 86
MEDIUM CSRF /bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 96

Copy link

Copy link

codecov bot commented Jun 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.78%. Comparing base (290fa3d) to head (537e4eb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5963   +/-   ##
=======================================
  Coverage   47.78%   47.78%           
=======================================
  Files        1697     1697           
  Lines       75270    75270           
  Branches     6786     6786           
=======================================
  Hits        35970    35970           
  Misses      37836    37836           
  Partials     1464     1464           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant