-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add clutches. #4787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 1.19.4
Are you sure you want to change the base?
Add clutches. #4787
Conversation
We need to define the items to clutch with in |
Hey! Maybe I can get to work on a UI? I was working on a swarm feature for Baritone and I think I have a good understanding of the codebase. Or maybe if there are any other features you'd like help with first? |
@ItsAGamer214 If you want to contribute to the repository, open up an issue. From there you can create a draft PR, commit to it, open it for review, and get it merged. A UI isn't in the scope of this specific issue but if you want to make one, feel free to do so. If you want to work on another thing instead, we have like 800 issues open (some are just trolls and others make no sense but there are still good ones that could be worked on). |
Actually, clutches should all be in their own separate classes extending an abstract class. That would be much cleaner. |
…stract class. Also rework logic.
Codacy is probably just failing because of that weird for loop that’s basically a while true. It should actually be checking until y=(whatever the minimum height is). |
…his also paves the way to bed clutches with the multiple types of beds involved.
Ladders and vines are able to be placed on stairs when the face is fully solid but the code doesn't let them. Looking at the source code for those blocks should help solve this. |
Only Codacy error is for long parameter lists and I'm just going to ignore that. |
…to not place on bottom.
It would be really cool if I just give each clutch a properties variable corresponding to an enum. This way, we could skip repeating code segments. ex. pickupable, disableBottomBlockClutch, waterlogging, etc. Then all the logic for those could just go in a helper interface. This all kind of makes it seem like clutches should be in their own separate folder and everything but I don't really know... |
…ariables needed and move clutches to a separate folder to avoid crowdedness.
Closes #3226
Just a few more clutches to Baritone.
I might've missed a few things so let me know if there's anything else. I would say camels but they aren't in 1.19.4. Also with water, we should be checking to make sure we aren't placing on something that wouldn't stop our fall and just waterlog the block. These include leaves, mangrove roots, top slabs, etc.
Also also with ladders and vines, we should be checking if there is a block north, south, east, or west of the ladder or vine being placed since it won't place otherwise.(done)allowInventory
is on.dest
spot on the floor all the way up tomaxFallHeightNoClutch
, so that we can either go right through the clutch or break a block to fall. Maybe even chaining multiple clutches together is also something that could happen but all of this seems like something I don't want to spend countless painful hours on to get even a rough draft working :(.MutableClutchResult
should also have a direction parameter to keep track of this. Edit: I just repeated myself... I'll keep it in though since it adds a few more details.Clutch
that usually defaults to the middle of the block but can be changed for ladders.