Update cron library to support time zones #6602
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gábor Lipták <gliptak@gmail.com>
gliptak
requested review from
3vilhamster,
Groxx,
Shaddoll,
davidporter-id-au,
demirkayaender,
dkrotx,
jakobht,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
Author
|
please approve workflow run |
| "time" | ||
|
|
||
| "github.com/robfig/cron" | ||
| "github.com/robfig/cron/v3" |
Member
There was a problem hiding this comment.
Can you please add example test cases in cron_test.go to validate the change?
Let's also test this e2e by running Cadence locally and triggering a cron workflow with custom timezone. Please update PR description with the testing/validation steps.
Author
There was a problem hiding this comment.
at this point this is a version bump. In a followup PR, I will add timezone test case (although at this point I'm not setup to run e2e test locally)
Member
There was a problem hiding this comment.
The PR can wait until the e2e tests are ready to avoid any potential issues if we cut a release.
davidporter-id-au
added a commit
that referenced
this pull request
Jul 22, 2025
What changed? This largely just picks https://github.com/temporalio/temporal/pull/2215/files and is a slightly updated version of #6602. See also discussion #6445, though I'm not updating tzdata for the container in this PR (will follow up if it's needed).
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Update cron library to support time zones
Why?
#6445
How did you test it?
Potential risks
Release notes
Documentation Changes