Skip to content

Is google-api-core dependency actually needed? #1250

Open
@micwoj92

Description

@micwoj92

Describe your environment.
Opencensus 0.11.4

Steps to reproduce.
Check code for google-api-core imports.

What is the expected behavior?
Some imports

What is the actual behavior?
No imports

Additional context.
I've seen pull request #1075 which tries to remove this dependency, but @aabmass said:

Ah, so this won't work because of one actual use of protobuf library here:

from google.protobuf.internal.encoder import _VarintBytes

However google.protobuf.internal.encoder is provided by protobuf package and not google-api-core. If there is something that I understand incorreclty, please let me know, thanks.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions