Skip to content

[HOTFIX] applying PR #4864 to release/2025-06-13 #4865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release/2025-06-13
Choose a base branch
from
Open

[HOTFIX] applying PR #4864 to release/2025-06-13 #4865

wants to merge 1 commit into from
+20 −27

Conversation

chroma-droid
Copy link

This PR cherry-picks the commit bfca2ee onto release/2025-06-13. If there are unresolved conflicts, please resolve them manually.

@rescrv @github-actions
[ENH] Make compactors purge the dirty markers from all log services (#…
546674f 
…4864)

## Description of changes

It's possible for a log to be on one service, migrate, and be on
another.  This leaves garbage on one dirty log.  The protocol is for a
compactor to call PurgeDirtyMarker to clear the dirty marker, but it
could be misrouted.

## Test plan

CI

## Documentation Changes

n/a
@chroma-droid chroma-droid requested a review from rescrv June 17, 2025 23:13
@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rescrv rescrv

Assignees

@rescrv rescrv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chroma-droid @rescrv