Skip to content

Improve usability of license.py #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

scottgigante
Copy link

Removes unused arguments and marks required subparser as required.

Before:

✗ python scripts/license.py
Traceback (most recent call last):
  File "/Users/scottgigante/git/ctvc/codecov/scripts/license.py", line 93, in <module>
    main()
  File "/Users/scottgigante/git/ctvc/codecov/scripts/license.py", line 83, in main
    print(pref.command)
          ^^^^^^^^^^^^
AttributeError: 'Namespace' object has no attribute 'command'

After:

✗ python scripts/license.py
usage: codecov key gen [-h] {new,check} ...
codecov key gen: error: the following arguments are required: {new,check}

Removes unused arguments and marks required subparser as required.

Before:
```
✗ python scripts/license.py
Traceback (most recent call last):
  File "/Users/scottgigante/git/ctvc/codecov/scripts/license.py", line 93, in <module>
    main()
  File "/Users/scottgigante/git/ctvc/codecov/scripts/license.py", line 83, in main
    print(pref.command)
          ^^^^^^^^^^^^
AttributeError: 'Namespace' object has no attribute 'command'
```

After:
```
✗ python scripts/license.py
usage: codecov key gen [-h] {new,check} ...
codecov key gen: error: the following arguments are required: {new,check}
```
Copy link

@Dev-Re2906 Dev-Re2906 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

publisher

Copy link

@Dev-Re2906 Dev-Re2906 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

publisher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants