Applied rules for tool messages #6263
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for continuedev canceled.
|
dosubot
bot
added
the
size:L
|
|
|
✨ No issues found! Your code is sparkling clean! ✨ |
sestinj
requested changes
Jun 24, 2025
There was a problem hiding this comment.
I think that we should start now with writing tests that cover the thunk logic. Probably vitest "integration" tests would be better than a unit test of all the individual thunks. Kent D. Dodds (seems important) seems to agree: https://redux.js.org/usage/writing-tests#guiding-principles
But just something that checks the state before / after is what seems important
Would be fine if the tests are light for now, but at least get to POC where we are comfortable writing more of them in the future
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rearranges our messaging thunks a bit so that construct messages is only called in one place and applied rules are added to tool messages as well