-
-
Notifications
You must be signed in to change notification settings - Fork 790
Load/store FAST keys for auto_login. #3693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Demo: Logging in with a password and catching a FAST token The token is in IndexedDB: Upon reloading, logs in using FAST: Upon logging out, the token is wiped from memory: |
reuse_keys | ||
---------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I chose to repurpose reuse_scram_keys to also cover FAST because they are so similar. But there's other options
- add a separate
reuse_fast_keys
option - make FAST always enabled, or maybe just a
fast
that defauls totrue
.
I'm not sure how is best or what your preferences are. Lemme know :)
Also clean up FAST *and* SCRAM keys on log out; otherwise, the credentials are still in the browser, and could be stolen, or reused simply by someone who knows to redefined conversejs-session-jid in localStorage. Depends on strophe/strophejs#839 TODO: * [ ] This *renames* reuse_scram_keys to reuse_keys to cover both FAST and SCRAM, so it should probably get a backwards-compatibility shim for the old name. * [ ] Drop my development environment edit to package.json (without there's no way to test because both repos need to be in sync)
"version": "4.0.0-rc0", | ||
"resolved": "https://registry.npmjs.org/strophe.js/-/strophe.js-4.0.0-rc0.tgz", | ||
"integrity": "sha512-9j2hR/OsxFX1gmqcsxNOQySrUUju0blHAmGB5g5EcdlVjWn19u+xHKEoXt4Ft8VPBB9rQR0jvtQkAJPpqM9XTw==", | ||
"version": "3.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I imagine before this lands I'll have to redo it against 4.0. Hopefully it's not too complicated :)
Hi @kousu, thank you for the effort you've put into this so far. I'm just writing to let you know this is still on my radar and I plan to do an in-depth review soon. |
Also clean up FAST and SCRAM keys on log out; otherwise, the credentials are still in the browser, and could be stolen, or reused simply by someone who knows to redefined conversejs-session-jid in localStorage.
Fixes #3144
Depends on strophe/strophejs#840. The bulk of the work is in that pull.
TODO:
Before submitting your request, please make sure the following conditions are met:
CHANGES.md
document it in
docs/source/configuration.rst
with
make check
or you can run them in the browser by runningmake serve
and then opening
http://localhost:8000/tests.html
.