Skip to content

Add Cypress Rules documentation #6215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
Jul 10, 2025
Merged

Conversation

marktnoonan
Copy link
Contributor

@marktnoonan marktnoonan commented Jul 1, 2025

The first Cypress Accessibility custom rule will go live this week, this PR creates the docs for that.

This PR also makes a few other changes to catch up on some missing changelog entries and do some other light cleanup.

Copy link

cypress bot commented Jul 1, 2025

cypress-documentation    Run #549

Run Properties:  status check passed Passed #549  •  git commit d6c96d0960: Update docs/accessibility/core-concepts/cypress-rules.mdx
Project cypress-documentation
Branch Review marktnoonan/app-quality-updates
Run status status check passed Passed #549
Run duration 03m 48s
Commit git commit d6c96d0960: Update docs/accessibility/core-concepts/cypress-rules.mdx
Committer Mark Noonan
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 309
View all changes introduced in this branch ↗︎
UI Coverage  10.99%
  Untested elements 2445  
  Tested elements 3  
Accessibility  96.99%
  Failed rules  1 critical   3 serious   4 moderate   0 minor
  Failed elements 25  

@marktnoonan marktnoonan requested a review from tbiethman July 7, 2025 21:26
@@ -9,6 +9,20 @@ sidebar_position: 200

# Changelog

## Week of 6/2/2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marktnoonan Did you mean to put the new rules in the changelog?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding now, ty!

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds documentation for the new Cypress custom accessibility rule and updates Results API docs to cover AWS CodeBuild and Drone CI support, along with minor cleanup and changelog entries.

  • Introduce a new “Cypress Rules” docs page outlining the first custom rule
  • Document AWS CodeBuild and Drone CI integration in both UI Coverage and Accessibility Results API
  • Remove outdated frontmatter props, fix a typo, and add missing changelog entries

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
docs/ui-coverage/results-api.mdx Added AWS CodeBuild & Drone CI tabs for UI Coverage Results API
docs/ui-coverage/get-started/introduction.mdx Removed obsolete sidebar_custom_props
docs/ui-coverage/changelog.mdx Added changelog entries for AWS CodeBuild and Drone CI support
docs/cloud/account-management/users.mdx Fixed typo (“Cypres” → “Cypress”)
docs/accessibility/results-api.mdx Added Basic example, baseline example, and Drone CI tab for Accessibility Results
docs/accessibility/guides/production-monitoring.mdx Updated title/label, improved example comments
docs/accessibility/get-started/introduction.mdx Removed obsolete sidebar_custom_props
docs/accessibility/core-concepts/cypress-rules.mdx New documentation page for the custom Cypress accessibility rule
docs/accessibility/changelog.mdx Added changelog entries for AWS CodeBuild and Drone CI support
Comments suppressed due to low confidence (5)

docs/ui-coverage/results-api.mdx:24

  • The - Drone entry doesn’t include a hyperlink; consider linking to your Drone CI integration docs consistent with the other providers.
- Drone

docs/ui-coverage/results-api.mdx:382

  • In the Drone YAML snippet, lines prefixed with * are not valid YAML. Replace * with - to define the validate step correctly.
* - name: validate

docs/accessibility/results-api.mdx:37

  • The - Drone bullet is missing a hyperlink; add a link to the Drone CI guide to match the format of the other CI providers.
- Drone

docs/accessibility/results-api.mdx:503

  • The Drone YAML snippet uses * prefixes for steps, which isn’t valid YAML. Use - to define each step.
* - name: validate

docs/accessibility/changelog.mdx:16

  • [nitpick] Since you've added a new Cypress custom rule page, add a corresponding changelog entry (e.g., under the relevant week) to note the introduction of the cy-semantic-html-warning rule.
## Week of 5/26/2025

#### `getAccessibilityResults` Arguments
#### How to use a previous run as a baseline

```javascript title="scripts/verifyAccessibilityResults.js"
Copy link
Preview

Copilot AI Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The baseline example duplicates the basic example above verbatim; consider consolidating or differentiating the two to reduce redundancy.

Copilot uses AI. Check for mistakes.

Co-authored-by: Tyler Biethman <tbiethman@gmail.com>
marktnoonan and others added 2 commits July 10, 2025 16:39
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marktnoonan I might work on reframing this to focus on the 'why you need this' portion of the doc first. You're leading with the 'what Cypress did' and it took me a while to figure out why this is important to me as a user of the product exactly.

Not going to block here, but I had some typo fixes as well.


# Cypress rules

In addition to running the default ruleset of the Axe-Core® library, Cypress develops custom rules that take advantage of the addition layer of information available in a test automation context. These rules are identified by a "Cypress Rule" badge, to distinguish them from the main Axe-Core® rule set.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In addition to running the default ruleset of the Axe-Core® library, Cypress develops custom rules that take advantage of the addition layer of information available in a test automation context. These rules are identified by a "Cypress Rule" badge, to distinguish them from the main Axe-Core® rule set.
In addition to running the default ruleset of the Axe-Core® library, Cypress offers custom rules that take advantage of the additional layer of information available in the test automation context. These rules are identified by a "Cypress Rule" badge, to distinguish them from the main Axe-Core® rule set.

marktnoonan and others added 4 commits July 10, 2025 16:51
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
Co-authored-by: Tyler Biethman <tbiethman@gmail.com>
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
@marktnoonan
Copy link
Contributor Author

@jennifer-shehane this is a good point. Let me see what I can come up with on that framing.

Maybe it should start with a section called "What are Cypress rues?" and "Why are custom rules needed?"

@marktnoonan
Copy link
Contributor Author

@jennifer-shehane I've updated the intro.

Co-authored-by: Tyler Biethman <tbiethman@gmail.com>
@marktnoonan marktnoonan merged commit a9d1caa into main Jul 10, 2025
11 checks passed
@marktnoonan marktnoonan deleted the marktnoonan/app-quality-updates branch July 10, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants