-
Notifications
You must be signed in to change notification settings - Fork 1.1k
docs: minimum linux requirements for electron 36 #6219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cypress-documentation
|
Project |
cypress-documentation
|
Branch Review |
glibc-electron-36
|
Run status |
|
Run duration | 04m 55s |
Commit |
|
Committer | Jennifer Shehane |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
308
|
View all changes introduced in this branch ↗︎ |
UI Coverage
10.97%
|
|
---|---|
|
2444
|
|
3
|
Accessibility
96.94%
|
|
---|---|
|
1 critical
3 serious
4 moderate
0 minor
|
|
26
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cacieprins I'm kind of not a fan overall of the table. It seems like it's highlighting what we don't support a lot more than we should. How long do we keep old OS's in this table for? It'd be simpler to only document what we DO support, which is what the existing doc does.
| Distribution | Version | Cypress 14 | Cypress 15 | | ||
| ------------------ | ---------------- | ---------- | ---------- | | ||
| **macOS** | 10.15 (Catalina) | ❌ | ❌ | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest removing the Cypress 14 column. The docs are meant to reflect 'current version' always aside from the Changelog and Migration Guide docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is is possible to add this and then add a commit that removes it and we rebase merge the commits into the main branch so we at least have the historical record some place?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't add this table! It makes it horribly complicated and difficult to maintain.
You're not really testing against all these operating systems and versions and listing them all is creating a whole lot of unnecessary support exposure.
99% of users are on Ubuntu / Debian / Fedora / Windows / macOS as can be seen from issues reported
4a94500
to
e788931
Compare
Prebuilt binaries for Linux are no longer compatible with Linux distributions based on glibc `<2.31`. | ||
This support is in line with Node.js's support for Linux in 20+. | ||
|
||
If you're using a Linux distribution based on glibc `<2.31`, for example, Ubuntu 18.04, RHEL 8, CentOS 8, AlmaLinux 8, Rocky Linux 8, you'll need to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although it is true that Ubuntu 18 won't work with Cypress 15, it was already removed in 2023 - see #5515 because it didn't meet the previous criteria for minimum glibc 2.28. So it could probably be removed from the list here. That is to say it is not compatible with Cypress 14 either, so it's nothing new for Cypress 15.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just for background information - attempting to install Cypress 14 on Ubuntu 18.04 definitely doesn't work:
$ n 16
copying : node/16.20.2
installed : v16.20.2 (with npm 8.19.4)
$ yarn add cypress
yarn add v1.22.22
info No lockfile found.
[1/4] Resolving packages...
[2/4] Fetching packages...
error cypress@14.5.1: The engine "node" is incompatible with this module. Expected version "^18.0.0 || ^20.0.0 || >=22.0.0". Got "16.20.2"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.
$ n 18
installing : node-v18.20.8
mkdir : /home/mike/n/n/versions/node/18.20.8
fetch : https://nodejs.org/dist/v18.20.8/node-v18.20.8-linux-x64.tar.xz
copying : node/18.20.8
node: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by node)
/home/mike/n/bin/node: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by /home/mike/n/bin/node)
installed : (with npm )
Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for making this change simpler and maintainable!
Close #6214