Skip to content

Commit 03dceca

Browse files
committed
add data attribute (data-key) for better testability, fixed #35
1 parent 43ad3cc commit 03dceca

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
### 3.0.0 - 03 May 2016
22
* update to angular-ui-bootstrap 1.x, fixed #26, #36
33
* show auto complete dropdown from the beginning on suggested value parameters, fixed #33
4+
* add data attribute (data-key) for better testability, fixed #35
45

56
### 2.2.0 - 30 March 2016
67
* add support for events on adding and removing search params, fixed #32

src/angular-advanced-searchbox.html

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
<a ng-href="" ng-click="removeSearchParam($index)" role="button">
99
<span class="remove glyphicon glyphicon-trash"></span>
1010
</a>
11-
<div class="key" ng-click="enterEditMode($event, $index)">{{searchParam.name}}:</div>
11+
<div class="key" data-key="{{searchParam.key}}" ng-click="enterEditMode($event, $index)">{{searchParam.name}}:</div>
1212
<div class="value">
1313
<span ng-show="!searchParam.editMode" ng-click="enterEditMode($event, $index)">{{searchParam.value}}</span>
1414
<input name="value"
@@ -45,6 +45,10 @@
4545
</div>
4646
<div class="search-parameter-suggestions" ng-show="parameters && focus">
4747
<span class="title">{{parametersLabel}}:</span>
48-
<span class="search-parameter" ng-repeat="param in parameters | filter:isUnsedParameter | limitTo:parametersDisplayLimit" ng-mousedown="addSearchParam(param)">{{param.name}}</span>
48+
<span class="search-parameter" ng-repeat="param in parameters | filter:isUnsedParameter | limitTo:parametersDisplayLimit"
49+
data-key="{{param.key}}"
50+
ng-mousedown="addSearchParam(param)">
51+
{{param.name}}
52+
</span>
4953
</div>
5054
</div>

0 commit comments

Comments
 (0)