"Use Data Bound Items" checkbox is missing in ListBox/ComboBox's SmartTag window for DemoConsole application

[Olina-Zhang]

.NET version

main branch of Winforms repo

Did it work in .NET Framework?

Yes

Did it work in any of the earlier releases of .NET Core or .NET 5+?

No

Issue description

In DemoConsole test app of WinForms repo, "Use Data Bound Items" checkbox is missing in ListBox/ComboBox's SmartTag window

.NET 10:

.NET framework 4.8.1:

Steps to reproduce

Test the sample app: DemoConsole in Winforms repo

[Tanya-Solyanik]

@ricardobossan - please root-cause this issue. I think it's caused by the missing data service in .NET10. If this is the case, we'll "won't fix" it.

[ricardobossan]

@ricardobossan - please root-cause this issue. I think it's caused by the missing data service in .NET10. If this is the case, we'll "won't fix" it.

I’ve debugged the JIT code and pinpointed the source of the issue. The missing “Use Data Bound Items” checkbox in the SmartTag window for ListBox/ComboBox in the .NET 5+ DemoConsole app is due to differences in the implementation of the GetSortedActionItems method between the .NET Framework and .NET 5+ versions of the DesignerActionPanel.

In .NET Framework, the ListControlBoundActionList.GetSortedActionItems method includes additional DesignerActionPropertyItems and headers when _boundMode is enabled or when the ListControl.DataSource is not null:

public override DesignerActionItemCollection GetSortedActionItems()
{
	DesignerActionItemCollection designerActionItemCollection = new DesignerActionItemCollection();
	designerActionItemCollection.Add(new DesignerActionPropertyItem("BoundMode", SR.GetString("BoundModeDisplayName"), SR.GetString("DataCategoryName"), SR.GetString("BoundModeDescription")));
	ListControl listControl = base.Component as ListControl;
	if (_boundMode || (listControl != null && listControl.DataSource != null))
	{
		_boundMode = true;
		designerActionItemCollection.Add(new DesignerActionHeaderItem(SR.GetString("BoundModeHeader"), SR.GetString("DataCategoryName")));
		designerActionItemCollection.Add(new DesignerActionPropertyItem("DataSource", SR.GetString("DataSourceDisplayName"), SR.GetString("DataCategoryName"), SR.GetString("DataSourceDescription")));
		designerActionItemCollection.Add(new DesignerActionPropertyItem("DisplayMember", SR.GetString("DisplayMemberDisplayName"), SR.GetString("DataCategoryName"), SR.GetString("DisplayMemberDescription")));
		designerActionItemCollection.Add(new DesignerActionPropertyItem("ValueMember", SR.GetString("ValueMemberDisplayName"), SR.GetString("DataCategoryName"), SR.GetString("ValueMemberDescription")));
		designerActionItemCollection.Add(new DesignerActionPropertyItem("BoundSelectedValue", SR.GetString("BoundSelectedValueDisplayName"), SR.GetString("DataCategoryName"), SR.GetString("BoundSelectedValueDescription")));
		return designerActionItemCollection;
	}
	designerActionItemCollection.Add(new DesignerActionHeaderItem(SR.GetString("UnBoundModeHeader"), SR.GetString("DataCategoryName")));
	designerActionItemCollection.Add(new DesignerActionMethodItem(this, "InvokeItemsDialog", SR.GetString("EditItemDisplayName"), SR.GetString("DataCategoryName"), SR.GetString("EditItemDescription"), includeAsDesignerVerb: true));
	return designerActionItemCollection;
}

However, in the .NET 5+ implementation (ListControlUnboundActionList.GetSortedActionItems), these items are no longer present:

public override DesignerActionItemCollection GetSortedActionItems()
{
    DesignerActionItemCollection returnItems =
    [
        new DesignerActionMethodItem(this, "InvokeItemsDialog",
            SR.ListControlUnboundActionListEditItemsDisplayName,
            SR.ItemsCategoryName,
            SR.ListControlUnboundActionListEditItemsDescription, true),
    ];
    return returnItems;
}

This omission leads to the “Use Data Bound Items” checkbox (and other related bound properties) not being displayed in the SmartTag panel for ListBox and ComboBox controls.

[LeafShi1]

Maybe we need to look at the history to see why the two codes are inconsistent.

[ricardobossan]

Data binding is not supported here, so this item is unnecessary. If any customer complains about this issue, we will review it again.