Add unit test for ButtonBaseAdapter.ColorOptions.cs file #13458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13458 +/- ##
====================================================
+ Coverage 62.21083% 76.59248% +14.38164%
====================================================
Files 3213 3231 +18
Lines 638302 639286 +984
Branches 47201 47304 +103
====================================================
+ Hits 397093 489645 +92552
+ Misses 234153 146062 -88091
+ Partials 7056 3579 -3477
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
LeafShi1
reviewed
May 16, 2025
src/test/unit/System.Windows.Forms/System/Windows/Forms/ButtonBaseAdapterTests.cs
Outdated
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/ButtonBaseAdapterTests.cs
Outdated
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/ButtonBaseAdapterTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new unit test file, ButtonBaseAdapterTests.cs, to improve test coverage for the ButtonStandardAdapter.cs file.
- Added multiple tests to validate ColorOptions behavior under different modes (default, non-SystemControl colors with high contrast on/off, and disabled states).
- Consolidates assertions for computed color values based on brightness and high contrast conditions.
src/test/unit/System.Windows.Forms/System/Windows/Forms/ButtonBaseAdapterTests.cs
Show resolved
Hide resolved
|
|
||
| data.ButtonFace.Should().Be(backColor); | ||
| data.ButtonShadow.Should().Be(ControlPaint.Dark(backColor)); | ||
| data.ButtonShadowDark.Should().Be(ControlPaint.LightLight(backColor)); |
There was a problem hiding this comment.
[nitpick] In high contrast mode, ButtonShadowDark is expected to be ControlPaint.LightLight(backColor) instead of the usual DarkDark. Adding a comment to explain this deviation would improve clarity for future maintainers.
Copilot uses AI. Check for mistakes.
Olina-Zhang
added
the
waiting-author-feedback
dotnet-policy-service
bot
removed
the
waiting-author-feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #13442
Proposed changes
Microsoft Reviewers: Open in CodeFlow