Add coverage for ToolStripContainer_ToolStripContainerTypedContro… #13527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelonWang1
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13527 +/- ##
===================================================
+ Coverage 76.59900% 76.61590% +0.01689%
===================================================
Files 3230 3238 +8
Lines 639165 639550 +385
Branches 47297 47319 +22
===================================================
+ Hits 489594 489997 +403
- Misses 145989 146022 +33
+ Partials 3582 3531 -51
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Open
48 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR adds unit tests for the ToolStripContainerTypedControlCollection to verify the collection’s behavior under various conditions (e.g., adding null values, handling read-only collections, and adding/removing valid and invalid control types).
- Adds tests for adding a null value and confirming no changes occur
- Validates exception throwing when the collection is read-only or when an invalid control type is added/removed
- Verifies proper behavior for setting child indices for valid control types
ricardobossan
requested changes
May 28, 2025
...rms/System/Windows/Forms/ToolStripContainer.ToolStripContainerTypedControlCollectionTests.cs
Outdated
Show resolved
Hide resolved
...rms/System/Windows/Forms/ToolStripContainer.ToolStripContainerTypedControlCollectionTests.cs
Outdated
Show resolved
Hide resolved
...rms/System/Windows/Forms/ToolStripContainer.ToolStripContainerTypedControlCollectionTests.cs
Show resolved
Hide resolved
dotnet-policy-service
bot
added
the
waiting-author-feedback
dotnet-policy-service
bot
removed
the
waiting-author-feedback
Epica3055
reviewed
Jun 16, 2025
...rms/System/Windows/Forms/ToolStripContainer.ToolStripContainerTypedControlCollectionTests.cs
Show resolved
Hide resolved
Epica3055
approved these changes
Jun 16, 2025
ricardobossan
approved these changes
Jun 16, 2025
KlausLoeffelmann
pushed a commit
to KlausLoeffelmann/winforms
that referenced
this pull request
Jun 16, 2025
…otnet#13527) * Add ode coverage for ToolStripContainer_ToolStripContainerTypedControlCollection * Handle feedback! * Updated!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #13442
Proposed changes
Microsoft Reviewers: Open in CodeFlow