Skip to content

Add unit test for GridToolTip.cs file #13533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 18, 2025
Merged

Add unit test for GridToolTip.cs file #13533

merged 3 commits into from
Jun 18, 2025

Conversation

Philip-Wang01
Copy link
Contributor

@Philip-Wang01 Philip-Wang01 commented May 28, 2025 •
edited by dotnet-policy-service bot
Loading

Related #13442

Proposed changes

  • Add unit test file: GridToolTipTests.cs for GridToolTip.cs file.
Microsoft Reviewers: Open in CodeFlow

@Philip-Wang01 Philip-Wang01 requested a review from a team as a code owner May 28, 2025 08:37
@codecov Codecov
Copy link

codecov bot commented May 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.59019%. Comparing base (5821493) to head (352bdcd).
Report is 102 commits behind head on main.

Additional details and impacted files 
@@                 Coverage Diff                  @@
##                main      #13533          +/-   ##
====================================================
+ Coverage   62.21083%   76.59019%   +14.37936%     
====================================================
  Files           3213        3253          +40     
  Lines         638302      640992        +2690     
  Branches       47201       47439         +238     
====================================================
+ Hits          397093      490937       +93844     
+ Misses        234153      146518       -87635     
+ Partials        7056        3537        -3519
Flag Coverage Δ
Debug 76.59019% <100.00000%> (+14.37936%) ⬆️
integration 18.48042% <ø> (-0.30837%) ⬇️
production 51.02835% <ø> (+32.23957%) ⬆️
test 97.41175% <100.00000%> (+0.00763%) ⬆️
unit 48.44166% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ricardobossan ricardobossan requested a review from Copilot May 29, 2025 19:52
@ricardobossan ricardobossan mentioned this pull request May 27, 2025
Open
48 tasks
Copilot
Copilot AI reviewed May 29, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces unit tests for the GridToolTip class to verify its functionality with respect to tooltip value setting, handling of null and empty strings, text truncation, resetting behavior, and handle creation.

  • Added comprehensive tests covering various tooltip value scenarios
  • Integrated handle creation validation through a Form-based test

...test/unit/System.Windows.Forms/System/Windows/Forms/PropertyGridInternal/GridToolTipTests.cs
public void GridToolTip_Reset()
{
_toolTip.ToolTip = "abc";
_toolTip.Reset();
Copy link
Preview

Copilot AI May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The 'GridToolTip_Reset' test expects the tooltip value to remain unchanged after calling Reset(). Consider adding a comment to clarify the intended behavior of Reset() to improve code clarity and maintainability.

Copilot uses AI. Check for mistakes.

ricardobossan
ricardobossan requested changes May 29, 2025
View reviewed changes
@dotnet-policy-service dotnet-policy-service bot added the waiting-author-feedback The team requires more information from the author label May 29, 2025
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label May 30, 2025
ricardobossan
ricardobossan previously approved these changes May 30, 2025
View reviewed changes
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Epica3055
Epica3055 reviewed Jun 16, 2025
View reviewed changes
...test/unit/System.Windows.Forms/System/Windows/Forms/PropertyGridInternal/GridToolTipTests.cs Outdated
Comment on lines 58 to 66
_toolTip.ToolTip = new('a', 1005);

_toolTip.ToolTip.Should().EndWith("...");
_toolTip.ToolTip.Length.Should().Be(1003);

_toolTip.ToolTip = new('b', 1000);

_toolTip.ToolTip.Should().NotEndWith("...");
_toolTip.ToolTip.Length.Should().Be(1000);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the readability and clarity, I think maybe it's better to introduce somthing like this private const int MaximumToolTipLength = 1000; , which is what did in GridToolTip.cs

@ricardobossan ricardobossan added the waiting-author-feedback The team requires more information from the author label Jun 16, 2025
@Epica3055 Epica3055 merged commit ece6f6d into dotnet:main Jun 18, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@Epica3055 Epica3055 Epica3055 approved these changes

@ricardobossan ricardobossan ricardobossan left review comments

Assignees

@Philip-Wang01 Philip-Wang01

Labels
area-test coverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Philip-Wang01 @ricardobossan @Epica3055