Skip to content

Fix 13288 by add Task.Delay for test ListView_Click_On_Second_Column_Does_Not_Alter_CheckBoxesAsync #13534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025

Conversation

LeafShi1
Copy link
Member

@LeafShi1 LeafShi1 commented May 28, 2025

Fixes #13288

Proposed changes

  • Add Task.Delay for test ListView_Click_On_Second_Column_Does_Not_Alter_CheckBoxesAsync
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.09826%. Comparing base (8376cfc) to head (cb9636e).
Report is 47 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (8376cfc) and HEAD (cb9636e). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (8376cfc) HEAD (cb9636e)
Debug 3 2
test 1 0
Additional details and impacted files
@@                 Coverage Diff                  @@
##                main      #13534          +/-   ##
====================================================
- Coverage   76.59900%   51.09826%   -25.50074%     
====================================================
  Files           3230        2054        -1176     
  Lines         639165      286636      -352529     
  Branches       47297       41946        -5351     
====================================================
- Hits          489594      146466      -343128     
+ Misses        145989      137347        -8642     
+ Partials        3582        2823         -759     
Flag Coverage Δ
Debug 51.09826% <ø> (-25.50075%) ⬇️
integration 18.87868% <ø> (+0.09402%) ⬆️
production 51.09826% <ø> (+0.09166%) ⬆️
test ?
unit 48.41855% <ø> (+0.01376%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LeafShi1 LeafShi1 added the waiting-review This item is waiting on review by one or more members of team label May 29, 2025
@ricardobossan
Copy link
Member

All LGTM!

@KlausLoeffelmann
Copy link
Member

Out of curiosity, would Application.DoEvents(); or await InvokeAsync(() => { }); also mitigate this?
(I figure await Task.Yield(); would not.)

@LeafShi1
Copy link
Member Author

Out of curiosity, would Application.DoEvents(); or await InvokeAsync(() => { }); also mitigate this?

Yes, Application.DoEvents(); and await form.InvokeAsync(() => { }); also mitigate this.

@KlausLoeffelmann
Copy link
Member

I would go for the InvokeAsync.
From my side, it's approved, so, you can approve it internally if you can, and merge it. Ping me, if you need my approval!

Copy link
Member

@KlausLoeffelmann KlausLoeffelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work — 加油!

@KlausLoeffelmann KlausLoeffelmann removed the waiting-review This item is waiting on review by one or more members of team label Jun 13, 2025
@LeafShi1 LeafShi1 merged commit 847c2a4 into dotnet:main Jun 16, 2025
8 checks passed
KlausLoeffelmann pushed a commit to KlausLoeffelmann/winforms that referenced this pull request Jun 16, 2025
…Does_Not_Alter_CheckBoxesAsync (dotnet#13534)

* Fix 13288 by add Task.Delay for test ListView_Click_On_Second_Column_Does_Not_Alter_CheckBoxesAsync
@LeafShi1 LeafShi1 deleted the Fix_13288_AddTaskDelay branch June 19, 2025 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unstable unit test: System.Windows.Forms.UITests.ListViewTests.ListView_Click_On_Second_Column_Does_Not_Alter_CheckBoxesAsync
3 participants