Add code coverage for DataGridViewImageColumn #13547
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13547 +/- ##
====================================================
+ Coverage 62.21083% 97.41463% +35.20380%
====================================================
Files 3213 1188 -2025
Lines 638302 353064 -285238
Branches 47201 5379 -41822
====================================================
- Hits 397093 343936 -53157
+ Misses 234153 8369 -225784
+ Partials 7056 759 -6297
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Zheng-Li01
added
the
waiting-review
Open
48 tasks
There was a problem hiding this comment.
Pull Request Overview
Adds comprehensive unit tests for the DataGridViewImageColumn class, covering its public properties and methods to improve code coverage.
- Introduces tests for property getters/setters:
Description,Icon,Image,ImageLayout,ValuesAreIcons - Adds tests for
Clone()behavior andToString()formatting - Verifies propagation of property changes to cell templates and existing rows
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewImageColumnTests.cs
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewImageColumnTests.cs
Show resolved
Hide resolved
ricardobossan
requested changes
Jun 4, 2025
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewImageColumnTests.cs
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewImageColumnTests.cs
Show resolved
Hide resolved
dotnet-policy-service
bot
added
the
waiting-author-feedback
dotnet-policy-service
bot
removed
the
waiting-author-feedback
LeafShi1
removed
the
waiting-review
LeafShi1
reviewed
Jun 16, 2025
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewImageColumnTests.cs
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewImageColumnTests.cs
Outdated
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewImageColumnTests.cs
Outdated
Show resolved
Hide resolved
LeafShi1
added
the
waiting-author-feedback
dotnet-policy-service
bot
removed
the
waiting-author-feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #13442
Proposed changes
Add unit test file:DataGridViewImageColumnTests.cs for public methods of the DataGridViewImageColumn.cs
Microsoft Reviewers: Open in CodeFlow