Skip to content

Fix All Dark mode Visual Style Renders #13591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

memoarfaa
Copy link

@memoarfaa memoarfaa commented Jun 13, 2025

Fixes #11950
Fixes #11949
Fixes #12909
Fixes #11893
Fixes #11901
Fixes #12040

Proposed changes

  • Enhanced dark mode visual style generation and selection logic, with custom handling for Button, ComboBox, Toolbar, Header, Status, and TreeView controls.
  • Improved consistency and accuracy of dark mode rendering, especially for high-DPI displays.

Customer Impact

  • More visually consistent dark mode experience for end users.
  • High-DPI setups now render dark mode elements correctly and reliably.

Regression?

  • No

Screenshots

Before

2025-06-13_21-23-24.mp4

After

2025-06-13_21-19-11.mp4

Test methodology

  • Manual testing across various controls in dark mode and high-DPI environments.
  • Verified correct rendering for affected controls.
  • Ran existing integration tests.

Test environment(s)

  • Tested on Windows 11, Latest .NET 10 SDK build: 10.0.100-preview.6.25311.107

UI scaling,

100% UI scaling and other UI scaling.

Microsoft Reviewers: Open in CodeFlow

@memoarfaa memoarfaa requested a review from a team as a code owner June 13, 2025 18:54
@github-actions github-actions bot added the area-DarkMode Issues relating to Dark Mode feature label Jun 13, 2025
@KlausLoeffelmann
Copy link
Member

KlausLoeffelmann commented Jun 13, 2025

Hey @memoarfaa,

let's please hold up the dark mode renderer work, until we have the next batch of PRs really merged and committed.

They need to go in this weekend otherwise they might even slip to 11.

After we have them in, we can gradually work on them and further improve.

Thanks!

Copy link

codecov bot commented Jun 13, 2025

Codecov Report

Attention: Patch coverage is 16.07143% with 47 lines in your changes missing coverage. Please review.

Project coverage is 51.00057%. Comparing base (44e2900) to head (f610037).
Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (44e2900) and HEAD (f610037). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (44e2900) HEAD (f610037)
Debug 3 2
test 1 0
Additional details and impacted files
@@                 Coverage Diff                  @@
##                main      #13591          +/-   ##
====================================================
- Coverage   76.59914%   51.00057%   -25.59858%     
====================================================
  Files           3236        2054        -1182     
  Lines         639344      286687      -352657     
  Branches       47314       41953        -5361     
====================================================
- Hits          489732      146212      -343520     
+ Misses        146085      137700        -8385     
+ Partials        3527        2775         -752     
Flag Coverage Δ
Debug 51.00057% <16.07143%> (-25.59858%) ⬇️
integration 18.54477% <16.07143%> (+0.00403%) ⬆️
production 51.00057% <16.07143%> (-0.00210%) ⬇️
test ?
unit 48.41622% <7.14286%> (+0.01859%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@memoarfaa
Copy link
Author

Hey @memoarfaa,

let's please hold up the dark mode renderer work, until we have the next batch of PRs really merged and committed.

They need to go in this weekend otherwise they might even slip to 11.

After we have them in, we can gradually work on them and further improve.

Thanks!

No, I want dark mode renderers in 10, so I'm going to turn this pull request into a draft until your pull requests are actually merged and committed.

@memoarfaa memoarfaa marked this pull request as draft June 13, 2025 19:38
@dotnet-policy-service dotnet-policy-service bot added the draft draft PR label Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment