Skip to content

[release/9.0] Update TreeView's TvnEndLabelEdit method to set label to null when no text has changed #13614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: release/9.0
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 18, 2025

Backport of #13588 to release/9.0

Fixes #13583

Proposed changes

Updates TvnEndLabelEdit to pass null for the new label when the text is unchanged, preventing exception scenarios on Enter key presses.

Customer Impact

  • The user can use the Enter key to exit the edit state of the TreeNode when the text has not changed.

Regression?

Testing

  • Manual testing with the user-provided project

Risk

  • Low

@github-actions github-actions bot requested a review from a team as a code owner June 18, 2025 06:31
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.85513%. Comparing base (615dd68) to head (cd68cf0).

Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/9.0      #13614         +/-   ##
=====================================================
+ Coverage     74.85339%   74.85513%   +0.00173%     
=====================================================
  Files             3022        3022                 
  Lines           630570      630570                 
  Branches         46810       46810                 
=====================================================
+ Hits            472003      472014         +11     
+ Misses          155171      155167          -4     
+ Partials          3396        3389          -7     
Flag Coverage Δ
Debug 74.85513% <75.00000%> (+0.00173%) ⬆️
integration 18.02368% <0.00000%> (+0.00316%) ⬆️
production 47.90503% <75.00000%> (+0.00386%) ⬆️
test 96.99900% <ø> (ø)
unit 44.92984% <75.00000%> (-0.00105%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LeafShi1 LeafShi1 self-assigned this Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant