Skip to content

[release/9.0] Add do...while loop in the SetValue method of SerializationResourceManager.cs until resourceName is unique #13615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: release/9.0
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 18, 2025

Backport of #13578 to release/9.0

Fixes #12595

Proposed changes

Replaces single conditional append with a do…while loop to retry name generation to ensures that SetValue in SerializationResourceManager.cs repeatedly generates a new resourceName until it’s unique, fixing duplicate suffixes when serializing collections.

Customer Impact

  • When serializing collection values, the resource numeric suffix can be incremented without duplication

Regression?

Testing

  • Manual testing with the user-provided project

Risk

  • Low

LeafShi1 and others added 2 commits June 18, 2025 06:31
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@github-actions github-actions bot requested a review from a team as a code owner June 18, 2025 06:31
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 74.85402%. Comparing base (615dd68) to head (7a093b4).

Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/9.0      #13615         +/-   ##
=====================================================
+ Coverage     74.85339%   74.85402%   +0.00063%     
=====================================================
  Files             3022        3022                 
  Lines           630570      630574          +4     
  Branches         46810       46811          +1     
=====================================================
+ Hits            472003      472010          +7     
- Misses          155171      155173          +2     
+ Partials          3396        3391          -5     
Flag Coverage Δ
Debug 74.85402% <0.00000%> (+0.00063%) ⬆️
integration 18.01320% <0.00000%> (-0.00732%) ⬇️
production 47.90295% <0.00000%> (+0.00178%) ⬆️
test 96.99900% <ø> (ø)
unit 44.93589% <0.00000%> (+0.00500%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LeafShi1 LeafShi1 self-assigned this Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant