Skip to content

Minimal install of codecore library; use current version #1619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Jun 29, 2025

This PR discontinues providing a package for codecore together with .vapi files etc as we no longer support third party plugins and the core plugins do no need them.

In passing the shared library version tracks the project version

The flatpak continues to build and run.

@jeremypw jeremypw marked this pull request as ready for review June 29, 2025 16:20
@jeremypw jeremypw added the Code improvement Desirable modernization of the code without affecting functionality or UI. label Jun 29, 2025
@jeremypw jeremypw added this to the 8.1 milestone Jun 29, 2025
@tintou
Copy link
Member

tintou commented Jun 30, 2025

The behavior of install_dir is specific in Vala, see https://mesonbuild.com/Vala.html#building-libraries

jeremypw and others added 2 commits June 30, 2025 09:41
Specify so version

Co-authored-by: Corentin Noël <tintou@noel.tf>
@jeremypw jeremypw changed the title Use default install location for codecore library; use current version Minimal install of codecore library; use current version Jun 30, 2025
@jeremypw
Copy link
Collaborator Author

@tintou Thanks for the info - the meson manual seems a bit contradictory/confusing with regard to the install_dir keyword parameter. Is issue #635 a valid issue that needs addressing? Do some versions of meson not accept the array of booleans?

Beyond that, do we need to publish the codecore library as a package at all? We do not support third-party plugins now. As far as I can tell the core plugins only need to find the .so file - they do not need the ,vapi, .deps or h files. My last commit removes the installation of these and Code still builds and runs normally. Or is this a step too far? @danirabbit thoughts?

@tintou
Copy link
Member

tintou commented Jun 30, 2025

array of booleans is supported since a very long time (I think since Meson supports Vala so almost its inception)

@jeremypw
Copy link
Collaborator Author

@tintou Thanks for clarifying and closing the issue. I'll leave this as draft for @danirabbit to comment on whether we want to continue publishing the codecore package.

@jeremypw jeremypw marked this pull request as draft June 30, 2025 10:25
@jeremypw
Copy link
Collaborator Author

@tintou Just to check - if we are not publishing codecore as a Vala library do we need the array of booleans - or are there other advantages to keeping the array?

@tintou
Copy link
Member

tintou commented Jun 30, 2025

If we are not allowing out-of-tree plugins there is no need to install the header/gir/vapi indeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code improvement Desirable modernization of the code without affecting functionality or UI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants