eth: reset skeleton after chain rewinded #32101
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I'm rewinding my chain to a old header, geth failed to importing the new blocks, log as below:
It seems that geth stucked at
Syncing beacon headers
, and later after I restarted geth, it continued to sync and import blocks.After some investigate, I think it is because after we rewinding the chain, the skeleton syncer's subchain state and the rewinded state are not matched. As a result, it will keep trying to sync headers that don't match the new chain, causing the repeating logs.
So here we simplify reset the skeleton to the fresh state to fix the data inconsistent.
BTW, I'm not sure if this fix was related to #32098