Skip to content

Fix prelease workflows for dry: false #33582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 23, 2025
Merged

Fix prelease workflows for dry: false #33582

merged 3 commits into from
Jun 23, 2025

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Jun 20, 2025

Summary

Follow-up to #33525

Fixes Unsupported tag: "false" (https://github.com/facebook/react/actions/runs/15773778995/job/44463562733#step:13:12) which also affects nightly releases.

How did you test this change?

@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Jun 20, 2025
@react-sizebot
Copy link

react-sizebot commented Jun 20, 2025

Comparing: 79d9aed...147f224

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.11% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 530.57 kB 530.57 kB = 93.67 kB 93.67 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.11% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 651.66 kB 651.66 kB = 114.78 kB 114.78 kB
facebook-www/ReactDOM-prod.classic.js = 674.81 kB 674.81 kB = 118.78 kB 118.78 kB
facebook-www/ReactDOM-prod.modern.js = 665.30 kB 665.30 kB = 117.19 kB 117.19 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 147f224

@eps1lon eps1lon force-pushed the sebbie/fix-wet-release branch from 67d4f45 to 30f00e0 Compare June 20, 2025 07:51
@eps1lon eps1lon requested a review from poteto June 20, 2025 07:57
@eps1lon eps1lon marked this pull request as ready for review June 20, 2025 07:57
Copy link

@hardanishsingh1 hardanishsingh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@poteto poteto merged commit fa3feba into main Jun 23, 2025
244 checks passed
@poteto poteto deleted the sebbie/fix-wet-release branch June 23, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants