Skip to content

[Flight] Add tests for component and owner stacks of halted components #33644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

unstubbable
Copy link
Collaborator

@unstubbable unstubbable commented Jun 25, 2025

This PR adds tests for the Node.js and Edge builds to verify that component stacks and owner stacks of halted components appear as expected, now that recent enhancements for those have been implemented (the latest one being #33634).

@unstubbable unstubbable changed the title Add failing test for stack frame source locations in halted components [Flight] Add failing test for stack frame source locations in halted components Jun 25, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Jun 25, 2025
@react-sizebot
Copy link

react-sizebot commented Jun 25, 2025

Comparing: 123ff13...d0981a9

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 530.57 kB 530.57 kB = 93.67 kB 93.67 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 651.66 kB 651.66 kB = 114.78 kB 114.78 kB
facebook-www/ReactDOM-prod.classic.js = 674.81 kB 674.81 kB = 118.78 kB 118.78 kB
facebook-www/ReactDOM-prod.modern.js = 665.30 kB 665.30 kB = 117.19 kB 117.19 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against d0981a9

@unstubbable unstubbable changed the title [Flight] Add failing test for stack frame source locations in halted components [Flight] Add tests for component and owner stacks of halted components Jun 25, 2025
@unstubbable unstubbable force-pushed the component-stack-locations-halt-test branch 2 times, most recently from fe8667e to 954c0c6 Compare June 25, 2025 19:51
@unstubbable unstubbable force-pushed the component-stack-locations-halt-test branch from 954c0c6 to d0981a9 Compare June 25, 2025 19:54
@unstubbable unstubbable marked this pull request as ready for review June 25, 2025 20:01
@unstubbable unstubbable requested a review from sebmarkbage June 25, 2025 20:01
@unstubbable unstubbable merged commit 9b2a545 into facebook:main Jun 25, 2025
244 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 25, 2025
#33644)

This PR adds tests for the Node.js and Edge builds to verify that
component stacks and owner stacks of halted components appear as
expected, now that recent enhancements for those have been implemented
(the latest one being #33634).

---------

Co-authored-by: Sebastian "Sebbie" Silbermann <silbermann.sebastian@gmail.com>

DiffTrain build for [9b2a545](9b2a545)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants