Update feature/secret-hiding with more recent iterations of patch series #5293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/secret-hiding #5293 +/- ##
=========================================================
- Coverage 81.81% 81.81% -0.01%
=========================================================
Files 250 250
Lines 27666 27635 -31
=========================================================
- Hits 22635 22609 -26
+ Misses 5031 5026 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
roypat
force-pushed
the
updated-patch-series
branch
3 times, most recently
from
6441b62 to
a33921e
Compare
kalyazin
reviewed
Jul 8, 2025
| @@ -531,18 +526,12 @@ pub fn build_microvm_from_snapshot( | |||
| params: &LoadSnapshotParams, | |||
| vm_resources: &mut VmResources, | |||
| ) -> Result<Arc<Mutex<Vmm>>, BuildMicrovmFromSnapshotError> { | |||
| // TODO: take it from kvm-bindings when userfault support is merged upstream | |||
| const KVM_CAP_USERFAULT: u32 = 241; | |||
There was a problem hiding this comment.
do we not check for it anymore?
There was a problem hiding this comment.
Ah, I think I originally forgot to update this and then noticed quite late into testing, so I just dropped the check instead of updating it with the correct number. But should readd this, thanks.
There was a problem hiding this comment.
seems like I broke this capability especially during the rebase. sign, well v13 just came out anyway, so guess new kernels it is
roypat
force-pushed
the
updated-patch-series
branch
3 times, most recently
from
b6a218f to
1e6c8eb
Compare
roypat
changed the title
10 tasks
roypat
force-pushed
the
updated-patch-series
branch
2 times, most recently
from
ff1c5d5 to
22ceb08
Compare
- Drop setting memory attributes to private (workaround was needed to get KVM to fault non-coco VMs through guest_memfd always) - Drop no-kvmclock (we have a workaround patch now) - Drop VM types (guest_memfd is now supported on all vm types). - Update kvm capability numbers Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
CONFIG_KVM_PRIVATE_MEM is dead, and CONFIG_KVM_GMEM which replaces it is automatically selected. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat
force-pushed
the
updated-patch-series
branch
6 times, most recently
from
170ce9d to
11970a6
Compare
With the updated host kernel, the bug that made them fail seems to have been fixed. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
Writing to the noturbo sysfs immediately locks up the entire instance, so stop doing this for now. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat
force-pushed
the
updated-patch-series
branch
from
11970a6 to
8dd1215
Compare
It's currently broken on the host kernel we're using. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade the base "mmap support for guest_memfd" series from Fuad's v4 to v12, and do all the Firecracker changes that come with it.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.