-
Notifications
You must be signed in to change notification settings - Fork 1.7k
in_kafka: add enable_auto_commit option for Kafka consumer #10412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces a new configuration option 'enable_auto_commit' to control Kafka message commit behavior. When disabled (default), messages are committed only after successful processing, providing better control over message processing guarantees. The option defaults to false to: - Prevent potential message loss in case of failures - Give users explicit control over commit behavior - Ensure messages are only committed after successful processing Users can enable auto-commit by setting enable_auto_commit true in their configuration if they prefer automatic batch commits. Signed-off-by: nareshku <nareshkumar4ever@gmail.com>
e127a16
to
7109f02
Compare
cosmo0920
reviewed
Jun 2, 2025
9004776
to
caa1b42
Compare
@nareshku Could you use |
…avior Signed-off-by: nareshku <nareshkumar4ever@gmail.com>
caa1b42
to
b69361f
Compare
cosmo0920
approved these changes
Jun 4, 2025
niedbalski
approved these changes
Jun 4, 2025
edsiper
requested changes
Jun 4, 2025
Signed-off-by: nareshku <nareshkumar4ever@gmail.com>
fe9b14e
to
43508d8
Compare
Thanks for this contribution, I have rebased this in a separate PR #10558 |
merged in #10558, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a new configuration option
enable_auto_commit
to control Kafka message commit behavior. When disabled (default), messages are committed only after successful processing, providing better control over message processing guarantees.Users can enable auto-commit by setting
enable_auto_commit true
in their configuration if they prefer automatic batch commits. When enabled the overall throughput will be higher.Fixes #9813
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Tested locally with the config
enable_auto_commit
option.Results: Below shows Fluent Bit input metrics captured at every 10s intervals.
(note: the throughput depends on the number of partition count, compression, etc.)
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.