Skip to content

lib: wasm: avoid executable stack as a result of wasm assembler. #10514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jkroonza
Copy link

Closes: #10513

@patrick-stephens patrick-stephens added dependencies Pull requests that update a dependency file and removed docs-required labels Jun 26, 2025
@patrick-stephens
Copy link
Contributor

patrick-stephens commented Jun 26, 2025

@jkroonza can you update the commits and PR title to follow the contribution guidelines? Plus follow the PR template as much as you can as it has important things in it to help reviewers and future devs who look at the PR.

Add a GUN-stack note to the assembly to state that an executable stack
is not required (by default a stack is executable unless stated
otherwise, this makes that statement).

Closes: fluent#10513
Signed-off-by: Jaco Kroon <jaco@uls.co.za>
@jkroonza
Copy link
Author

@jkroonza can you update the commits and PR title to follow the contribution guidelines? Plus follow the PR template as much as you can as it has important things in it to help reviewers and future devs who look at the PR.

Should be more in line now?

I also note that special action may be required to get this into the next minor release? Is that correct? If so, what do I need to do?

@patrick-stephens
Copy link
Contributor

Ah, this is an update to the dependency - we do not do that directly as it is a nightmare to manage future updates from upstream. Instead the approach is to merge the PR upstream and get a release there we can then update Fluent Bit with.

@patrick-stephens patrick-stephens changed the title Avoid executable stack as a result of wasm assembler. lib: wasm: avoid executable stack as a result of wasm assembler. Jun 26, 2025
@jkroonza
Copy link
Author

Welcome to close then :).

I've already included the patch locally into gentoo, so no harm no foul, but it is indeed quite annoying that these issues still crop up in 2025.

@jkroonza jkroonza closed this Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

executable stack
2 participants