-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: enable customization sentry DSN endpoint #3747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable customization sentry DSN endpoint #3747
Conversation
9896684
to
c744d97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's avoid duplication :)
786c7f0
to
dd2b734
Compare
feat: enable customization sentry DSN endpoint Update sentry/sentry.conf.example.py Co-authored-by: Amin Vakil <info@aminvakil.com>
dd2b734
to
b8bd9ec
Compare
@hubertdeng123 @BYK anyone wanna take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh interesting, thanks for bringing this up! May also want to add a reason why people may want to use this over URL_PREFIX
?
@BYK like me, I have different domain for ingestion and web UI. That way, the web UI can only be accessed via private corporate network, and the ingestion can be accessed publicly. |
@aldy505 that is the exact kind of comment I wanted to see in the code not on GitHub 😉 |
It is possible to customize DSN url by the configuration in sentry.conf.py.
This configuration option is added in sentry.conf.example.py.
#3744
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.