Skip to content

feat: enable customization sentry DSN endpoint #3747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2025

Conversation

yildizozgur
Copy link
Contributor

@yildizozgur yildizozgur commented Jun 13, 2025

It is possible to customize DSN url by the configuration in sentry.conf.py.
This configuration option is added in sentry.conf.example.py.
#3744

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@yildizozgur yildizozgur force-pushed the CustomizeSentryEndpoint branch from 9896684 to c744d97 Compare June 13, 2025 12:36
Copy link
Collaborator

@aminvakil aminvakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's avoid duplication :)

@yildizozgur yildizozgur force-pushed the CustomizeSentryEndpoint branch 2 times, most recently from 786c7f0 to dd2b734 Compare June 16, 2025 08:59
feat: enable customization sentry DSN endpoint

Update sentry/sentry.conf.example.py

Co-authored-by: Amin Vakil <info@aminvakil.com>
@yildizozgur yildizozgur force-pushed the CustomizeSentryEndpoint branch from dd2b734 to b8bd9ec Compare June 17, 2025 13:17
@aldy505
Copy link
Collaborator

aldy505 commented Jun 18, 2025

@hubertdeng123 @BYK anyone wanna take a look?

Copy link
Member

@BYK BYK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh interesting, thanks for bringing this up! May also want to add a reason why people may want to use this over URL_PREFIX?

@aldy505
Copy link
Collaborator

aldy505 commented Jun 19, 2025

Oh interesting, thanks for bringing this up! May also want to add a reason why people may want to use this over URL_PREFIX?

@BYK like me, I have different domain for ingestion and web UI. That way, the web UI can only be accessed via private corporate network, and the ingestion can be accessed publicly.

@aldy505 aldy505 enabled auto-merge (squash) June 19, 2025 00:58
@aldy505 aldy505 merged commit 43d7d96 into getsentry:master Jun 19, 2025
5 checks passed
@BYK
Copy link
Member

BYK commented Jun 19, 2025

@aldy505 that is the exact kind of comment I wanted to see in the code not on GitHub 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants